Skip to content

Add Moving MNIST dataset #6981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tsugumi-sys opened this issue Nov 28, 2022 · 1 comment · Fixed by #7042
Closed

Add Moving MNIST dataset #6981

tsugumi-sys opened this issue Nov 28, 2022 · 1 comment · Fixed by #7042

Comments

@tsugumi-sys
Copy link
Contributor

tsugumi-sys commented Nov 28, 2022

🚀 The feature

I would like to add MovingMNIST dataset.

Motivation, pitch

A lot of people uses Moving MNIST dataset for evaluating their proposed models according to PaperWithCode.

Alternatives

No response

Additional context

I've implemented Movning MNIST dataset in my personal project. So I would like to make a PR based on this.

I checked #3562 and #2690.

@pmeier @yassineAlouini
From this comment in #2690, I might should add to torchvision/prototype/datasets/_builtin. So where should I add Moving MNIST dataset ?

cc @pmeier

@pmeier
Copy link
Collaborator

pmeier commented Dec 7, 2022

Hey @tsugumi-sys, sorry for the late reply. Yes, we would accept a PR adding the dataset! Fortunately for this, the prototype datasets are currently on hold and so you can add it to torchvision.datasets directly. Meaning, we can probably re-use most of what you already implemented.

I've skimmed your linked implementation and it seems this is going into the right direction. In #2690 (review) I had quite a few concerns regarding the first draft of the other PR. Please make sure to address them on yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants