From 26cf7d8f69718a2c47e6c47402ccd35267660fd1 Mon Sep 17 00:00:00 2001
From: Philip Meier <github.pmeier@posteo.de>
Date: Fri, 10 Mar 2023 10:06:11 +0100
Subject: [PATCH 01/12] [PoC] migrate docs workflow to GHA

---
 .circleci/config.yml       | 112 -------------------------------------
 .circleci/config.yml.in    |  67 ----------------------
 .circleci/regenerate.py    |  39 +------------
 .github/workflows/docs.yml |  41 ++++++++++++++
 4 files changed, 42 insertions(+), 217 deletions(-)
 create mode 100644 .github/workflows/docs.yml

diff --git a/.circleci/config.yml b/.circleci/config.yml
index e1552f8e4df..6d43ceeeb96 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -869,73 +869,6 @@ jobs:
             conda activate python39
             packaging/build_cmake.sh
 
-  build_docs:
-    <<: *binary_common
-    docker:
-      - image: cimg/python:3.8
-    resource_class: 2xlarge+
-    steps:
-      - attach_workspace:
-          at: ~/workspace
-      - checkout
-      - download_model_weights
-      - run:
-          name: Setup
-          command: .circleci/unittest/linux/scripts/setup_env.sh
-      - designate_upload_channel
-      - run:
-          name: Install torchvision
-          command: .circleci/unittest/linux/scripts/install.sh
-      - run:
-          name: Build docs
-          command: |
-            set -ex
-            # turn v1.12.0rc3 into 1.12.0
-            tag=$(echo $CIRCLE_TAG | sed -e 's/v*\([0-9.]*\).*/\1/')
-            VERSION=${tag:-main}
-            eval "$(./conda/bin/conda shell.bash hook)"
-            conda activate ./env
-            pushd docs
-            pip install --progress-bar=off -r requirements.txt
-            make html
-            popd
-      - persist_to_workspace:
-          root: ./
-          paths:
-            - "*"
-      - store_artifacts:
-          path: ./docs/build/html
-          destination: docs
-
-  upload_docs:
-    <<: *binary_common
-    docker:
-      - image: "pytorch/manylinux-cuda100"
-    resource_class: 2xlarge+
-    steps:
-      - attach_workspace:
-          at: ~/workspace
-      - run:
-          name: Generate netrc
-          command: |
-            # set credentials for https pushing
-            # requires the org-member context
-            cat > ~/.netrc \<<DONE
-              machine github.com
-              login pytorchbot
-              password ${GITHUB_PYTORCHBOT_TOKEN}
-            DONE
-      - run:
-          name: Upload docs
-          command: |
-            # Don't use "checkout" step since it uses ssh, which cannot git push
-            # https://circleci.com/docs/2.0/configuration-reference/#checkout
-            set -ex
-            # Change v1.12.1rc1 into 1.12 (only major.minor)
-            tag=$(echo $CIRCLE_TAG | sed -e 's/v*\([0-9]*\.[0-9]*\).*/\1/')
-            target=${tag:-main}
-            ~/workspace/.circleci/build_docs/commit_docs.sh ~/workspace $target
-
 
 workflows:
   lint:
@@ -944,17 +877,6 @@ workflows:
 
   build:
     jobs:
-      - binary_linux_wheel:
-          conda_docker_image: pytorch/conda-builder:cpu
-          cu_version: cpu
-          filters:
-            branches:
-              only: /.*/
-            tags:
-              only: /v[0-9]+(\.[0-9]+)*-rc[0-9]+/
-          name: binary_linux_wheel_py3.8_cpu
-          python_version: '3.8'
-          wheel_docker_image: pytorch/manylinux-cpu
       - binary_win_wheel:
           cu_version: cpu
           filters:
@@ -1151,29 +1073,6 @@ workflows:
           cu_version: cu118
           name: binary_win_conda_py3.11_cu118
           python_version: '3.11'
-      - build_docs:
-          filters:
-            branches:
-              only:
-              - /.*/
-            tags:
-              only: /v[0-9]+(\.[0-9]+)*-rc[0-9]+/
-          name: build_docs
-          python_version: '3.8'
-          requires:
-          - binary_linux_wheel_py3.8_cpu
-      - upload_docs:
-          context: org-member
-          filters:
-            branches:
-              only:
-              - nightly
-            tags:
-              only: /v[0-9]+(\.[0-9]+)*-rc[0-9]+/
-          name: upload_docs
-          python_version: '3.8'
-          requires:
-          - build_docs
       - binary_ios_build:
           build_environment: binary-libtorchvision_ops-ios-12.0.0-x86_64
           ios_arch: x86_64
@@ -1301,17 +1200,6 @@ workflows:
               only:
               - nightly
           name: nightly_binary_libtorchvision_ops_android_upload
-      - binary_linux_wheel:
-          conda_docker_image: pytorch/conda-builder:cpu
-          cu_version: cpu
-          filters:
-            branches:
-              only: nightly
-            tags:
-              only: /v[0-9]+(\.[0-9]+)*-rc[0-9]+/
-          name: nightly_binary_linux_wheel_py3.8_cpu
-          python_version: '3.8'
-          wheel_docker_image: pytorch/manylinux-cpu
       - binary_win_wheel:
           cu_version: cpu
           filters:
diff --git a/.circleci/config.yml.in b/.circleci/config.yml.in
index b86ee3077eb..8dcc1dcbb15 100644
--- a/.circleci/config.yml.in
+++ b/.circleci/config.yml.in
@@ -869,73 +869,6 @@ jobs:
             conda activate python39
             packaging/build_cmake.sh
 
-  build_docs:
-    <<: *binary_common
-    docker:
-      - image: cimg/python:3.8
-    resource_class: 2xlarge+
-    steps:
-      - attach_workspace:
-          at: ~/workspace
-      - checkout
-      - download_model_weights
-      - run:
-          name: Setup
-          command: .circleci/unittest/linux/scripts/setup_env.sh
-      - designate_upload_channel
-      - run:
-          name: Install torchvision
-          command: .circleci/unittest/linux/scripts/install.sh
-      - run:
-          name: Build docs
-          command: |
-            set -ex
-            # turn v1.12.0rc3 into 1.12.0
-            tag=$(echo $CIRCLE_TAG | sed -e 's/v*\([0-9.]*\).*/\1/')
-            VERSION=${tag:-main}
-            eval "$(./conda/bin/conda shell.bash hook)"
-            conda activate ./env
-            pushd docs
-            pip install --progress-bar=off -r requirements.txt
-            make html
-            popd
-      - persist_to_workspace:
-          root: ./
-          paths:
-            - "*"
-      - store_artifacts:
-          path: ./docs/build/html
-          destination: docs
-
-  upload_docs:
-    <<: *binary_common
-    docker:
-      - image: "pytorch/manylinux-cuda100"
-    resource_class: 2xlarge+
-    steps:
-      - attach_workspace:
-          at: ~/workspace
-      - run:
-          name: Generate netrc
-          command: |
-            # set credentials for https pushing
-            # requires the org-member context
-            cat > ~/.netrc \<<DONE
-              machine github.com
-              login pytorchbot
-              password ${GITHUB_PYTORCHBOT_TOKEN}
-            DONE
-      - run:
-          name: Upload docs
-          command: |
-            # Don't use "checkout" step since it uses ssh, which cannot git push
-            # https://circleci.com/docs/2.0/configuration-reference/#checkout
-            set -ex
-            # Change v1.12.1rc1 into 1.12 (only major.minor)
-            tag=$(echo $CIRCLE_TAG | sed -e 's/v*\([0-9]*\.[0-9]*\).*/\1/')
-            target=${tag:-main}
-            ~/workspace/.circleci/build_docs/commit_docs.sh ~/workspace $target
-
 
 workflows:
   lint:
diff --git a/.circleci/regenerate.py b/.circleci/regenerate.py
index 2c8b6090138..ae54ace848d 100755
--- a/.circleci/regenerate.py
+++ b/.circleci/regenerate.py
@@ -61,12 +61,8 @@ def build_workflows(prefix="", filter_branch=None, upload=False, indentation=6,
                             fb = "/.*/"
 
                         # Disable all Linux Wheels Workflows from CircleCI
-                        # since those will now be done through Nova. We'll keep
-                        # around the py3.8 CPU Linux Wheels build since the docs
-                        # job depends on it.
                         if os_type == "linux" and btype == "wheel":
-                            if not (python_version == "3.8" and cu_version == "cpu"):
-                                continue
+                            continue
 
                         # Disable all Macos Wheels Workflows from CircleCI.
                         if os_type == "macos" and btype == "wheel":
@@ -80,10 +76,6 @@ def build_workflows(prefix="", filter_branch=None, upload=False, indentation=6,
                             btype, os_type, python_version, cu_version, unicode, prefix, upload, filter_branch=fb
                         )
 
-    if not filter_branch:
-        # Build on every pull request, but upload only on nightly and tags
-        w += build_doc_job("/.*/")
-        w += upload_doc_job("nightly")
     return indent(indentation, w)
 
 
@@ -114,35 +106,6 @@ def workflow_pair(btype, os_type, python_version, cu_version, unicode, prefix=""
     return w
 
 
-def build_doc_job(filter_branch):
-    job = {
-        "name": "build_docs",
-        "python_version": "3.8",
-        "requires": [
-            "binary_linux_wheel_py3.8_cpu",
-        ],
-    }
-
-    if filter_branch:
-        job["filters"] = gen_filter_branch_tree(filter_branch, tags_list=RC_PATTERN)
-    return [{"build_docs": job}]
-
-
-def upload_doc_job(filter_branch):
-    job = {
-        "name": "upload_docs",
-        "context": "org-member",
-        "python_version": "3.8",
-        "requires": [
-            "build_docs",
-        ],
-    }
-
-    if filter_branch:
-        job["filters"] = gen_filter_branch_tree(filter_branch, tags_list=RC_PATTERN)
-    return [{"upload_docs": job}]
-
-
 manylinux_images = {
     "cu117": "pytorch/manylinux-cuda117",
     "cu118": "pytorch/manylinux-cuda118",
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
new file mode 100644
index 00000000000..215347b1185
--- /dev/null
+++ b/.github/workflows/docs.yml
@@ -0,0 +1,41 @@
+name: docs
+
+on:
+  pull_request:
+  push:
+    branches:
+      - nightly
+      - main
+      - release/*
+  workflow_dispatch:
+
+jobs:
+  build:
+    uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
+    id: build
+    with:
+      repository: pytorch/vision
+      upload-artifact: docs
+      script: |
+        set -euo pipefail
+
+        export PYTHON_VERSION=3.8
+        export GPU_ARCH_TYPE=cpu
+        ./.github/scripts/setup-env.sh
+        
+        # Prepare conda
+        CONDA_PATH=$(which conda)
+        eval "$(${CONDA_PATH} shell.bash hook)"
+        conda activate ci
+        
+        cd docs
+        
+        echo '::group::Install doc requirements'
+        pip install --progress-bar=off -r requirements.txt
+        echo '::endgroup::'
+        
+        echo '::group::Build HTML docs'
+        make html
+        echo '::endgroup::'
+        
+        mv build/html "${RUNNER_ARTIFACT_DIR}"

From 77db8771b827c2ace6f1b52eb401a8a50154b521 Mon Sep 17 00:00:00 2001
From: Philip Meier <github.pmeier@posteo.de>
Date: Fri, 10 Mar 2023 10:13:05 +0100
Subject: [PATCH 02/12] remove wrong id

---
 .github/workflows/docs.yml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index 215347b1185..a958ff3256f 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -12,7 +12,6 @@ on:
 jobs:
   build:
     uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
-    id: build
     with:
       repository: pytorch/vision
       upload-artifact: docs

From 267e9436931019dc13c89ead1254b7105cdc8371 Mon Sep 17 00:00:00 2001
From: Philip Meier <github.pmeier@posteo.de>
Date: Fri, 10 Mar 2023 10:21:10 +0100
Subject: [PATCH 03/12] add ebug

---
 .github/workflows/docs.yml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index a958ff3256f..e85364d9ef6 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -1,4 +1,4 @@
-name: docs
+name: Docs
 
 on:
   pull_request:
@@ -15,6 +15,7 @@ jobs:
     with:
       repository: pytorch/vision
       upload-artifact: docs
+      timeout: 120
       script: |
         set -euo pipefail
 
@@ -33,6 +34,8 @@ jobs:
         pip install --progress-bar=off -r requirements.txt
         echo '::endgroup::'
         
+        sleep 7200
+        
         echo '::group::Build HTML docs'
         make html
         echo '::endgroup::'

From 548a7caa3adc598d6b9cfbcf9fafa0fe89cf4f5f Mon Sep 17 00:00:00 2001
From: Philip Meier <github.pmeier@posteo.de>
Date: Fri, 10 Mar 2023 10:45:36 +0100
Subject: [PATCH 04/12] fix linker path

---
 .github/workflows/docs.yml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index e85364d9ef6..a540ed8bcc7 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -27,6 +27,12 @@ jobs:
         CONDA_PATH=$(which conda)
         eval "$(${CONDA_PATH} shell.bash hook)"
         conda activate ci
+        # FIXME: not sure why we need this. `ldd torchvision/video_reader.so` shows that it
+        #  already links against the one pulled from conda. However, at runtime it pulls from
+        #  /lib64
+        # Should we maybe always do this in `./.github/scripts/setup-env.sh` so that we don't
+        # have to pay attention in all other workflows?
+        export LD_LIBRARY_PATH="${CONDA_PREFIX}/lib:${LD_LIBRARY_PATH}"
         
         cd docs
         

From 98d4f56f0fe8dfd5be49a489db8840609830e54e Mon Sep 17 00:00:00 2001
From: Philip Meier <github.pmeier@posteo.de>
Date: Fri, 10 Mar 2023 10:53:18 +0100
Subject: [PATCH 05/12] try larger runner

---
 .github/workflows/docs.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index a540ed8bcc7..b331ceefb22 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -14,6 +14,7 @@ jobs:
     uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
     with:
       repository: pytorch/vision
+      runner: linux.24xlarge
       upload-artifact: docs
       timeout: 120
       script: |

From 8010a129a490174f453515b06bc5e8574caa5968 Mon Sep 17 00:00:00 2001
From: Philip Meier <github.pmeier@posteo.de>
Date: Fri, 10 Mar 2023 11:25:01 +0100
Subject: [PATCH 06/12] limit number of parallel processes

---
 .github/workflows/docs.yml | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index b331ceefb22..28795bd7970 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -14,9 +14,7 @@ jobs:
     uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
     with:
       repository: pytorch/vision
-      runner: linux.24xlarge
       upload-artifact: docs
-      timeout: 120
       script: |
         set -euo pipefail
 
@@ -41,9 +39,10 @@ jobs:
         pip install --progress-bar=off -r requirements.txt
         echo '::endgroup::'
         
-        sleep 7200
-        
         echo '::group::Build HTML docs'
+        # The runner does not have sufficient memory to run with as many processes as their are
+        # cores (`-j auto`). Thus, we limit to 4 (`-j 4`) here.
+        sed -i -e 's/-j auto/-j 4/' Makefile
         make html
         echo '::endgroup::'
         

From b3ff0f97a1a2568471750a2efd09824ac0ed40ad Mon Sep 17 00:00:00 2001
From: Philip Meier <github.pmeier@posteo.de>
Date: Fri, 10 Mar 2023 11:30:49 +0100
Subject: [PATCH 07/12] single process

---
 .github/workflows/docs.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index 28795bd7970..dad2266a0f3 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -41,8 +41,8 @@ jobs:
         
         echo '::group::Build HTML docs'
         # The runner does not have sufficient memory to run with as many processes as their are
-        # cores (`-j auto`). Thus, we limit to 4 (`-j 4`) here.
-        sed -i -e 's/-j auto/-j 4/' Makefile
+        # cores (`-j auto`). Thus, we limit to a single process (`-j 1`) here.
+        sed -i -e 's/-j auto/-j 1/' Makefile
         make html
         echo '::endgroup::'
         

From eb77d0f60ce1cc266888d6a83d21663d9dabf518 Mon Sep 17 00:00:00 2001
From: Philip Meier <github.pmeier@posteo.de>
Date: Mon, 13 Mar 2023 21:23:32 +0100
Subject: [PATCH 08/12] try docs upload

---
 .github/workflows/docs.yml | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index dad2266a0f3..576b892ce39 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -47,3 +47,27 @@ jobs:
         echo '::endgroup::'
         
         mv build/html "${RUNNER_ARTIFACT_DIR}"
+
+  upload-preview:
+    if: github.event_name == 'pull_request'
+    needs: [build]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/download-artifact@v3
+        with:
+          name: docs
+
+      - name: Debug
+        run: |
+          sudo apt -y update && sudo apt -y install tree
+          ls -la
+          tree docs
+
+      - name: Upload docs preview
+        uses: seemethere/upload-artifact-s3@v5
+        with:
+          retention-days: 14
+          s3-bucket: doc-previews
+          if-no-files-found: error
+          path: docs/build/html
+          s3-prefix: pytorch/vision/${{ github.event.pull_request.number }}

From 0620cf6b5956e0feafe06c197270cd9ca86b859f Mon Sep 17 00:00:00 2001
From: Philip Meier <github.pmeier@posteo.de>
Date: Mon, 13 Mar 2023 21:27:35 +0100
Subject: [PATCH 09/12] fix env var

---
 .github/workflows/docs.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index 576b892ce39..d27e82df98a 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -20,6 +20,7 @@ jobs:
 
         export PYTHON_VERSION=3.8
         export GPU_ARCH_TYPE=cpu
+        export GPU_ARCH_VERSION=''
         ./.github/scripts/setup-env.sh
         
         # Prepare conda

From 4506642b87037625fc399e71bd9f3865b41105ea Mon Sep 17 00:00:00 2001
From: Philip Meier <github.pmeier@posteo.de>
Date: Mon, 13 Mar 2023 21:36:37 +0100
Subject: [PATCH 10/12] fix path

---
 .github/workflows/docs.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index d27e82df98a..e65f4c9ce7c 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -62,7 +62,7 @@ jobs:
         run: |
           sudo apt -y update && sudo apt -y install tree
           ls -la
-          tree docs
+          tree html
 
       - name: Upload docs preview
         uses: seemethere/upload-artifact-s3@v5
@@ -70,5 +70,5 @@ jobs:
           retention-days: 14
           s3-bucket: doc-previews
           if-no-files-found: error
-          path: docs/build/html
+          path: html
           s3-prefix: pytorch/vision/${{ github.event.pull_request.number }}

From 7b0ebd2d184c387077f51c6c09bb4a9cbbf0a5e9 Mon Sep 17 00:00:00 2001
From: Nikita Shulga <nikita.shulga@gmail.com>
Date: Wed, 15 Mar 2023 11:52:43 -0700
Subject: [PATCH 11/12] Update .github/workflows/docs.yml

---
 .github/workflows/docs.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index e65f4c9ce7c..b46cd9a69e2 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -52,7 +52,7 @@ jobs:
   upload-preview:
     if: github.event_name == 'pull_request'
     needs: [build]
-    runs-on: ubuntu-latest
+    runs-on: [self-hosted, linux.2xlarge]
     steps:
       - uses: actions/download-artifact@v3
         with:

From 64f77ff71f725b06d9076b7b75f30fccc381aba7 Mon Sep 17 00:00:00 2001
From: Nikita Shulga <nikita.shulga@gmail.com>
Date: Wed, 15 Mar 2023 12:02:38 -0700
Subject: [PATCH 12/12] Update .github/workflows/docs.yml

---
 .github/workflows/docs.yml | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index b46cd9a69e2..22ff4ab84b3 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -58,12 +58,6 @@ jobs:
         with:
           name: docs
 
-      - name: Debug
-        run: |
-          sudo apt -y update && sudo apt -y install tree
-          ls -la
-          tree html
-
       - name: Upload docs preview
         uses: seemethere/upload-artifact-s3@v5
         with: