Skip to content

Commit de208d3

Browse files
authored
Merge pull request #8645 from PumasAI/jk/quartonotebookrunner
Native Julia engine based on QuartoNotebookRunner.jl
2 parents 2537808 + 082f7fe commit de208d3

File tree

13 files changed

+826
-36
lines changed

13 files changed

+826
-36
lines changed

.github/workflows/test-smokes.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ jobs:
115115
run: |
116116
if (!requireNamespace('renv', quietly = TRUE)) install.packages('renv')
117117
renv::restore()
118-
# Install dev versions for our testing
118+
# Install dev versions for our testing
119119
# Use r-universe to avoid github api calls
120120
try(install.packages('knitr', repos = 'https://yihui.r-universe.dev'))
121121
try(install.packages('rmarkdown', repos = 'https://rstudio.r-universe.dev'))
@@ -164,7 +164,7 @@ jobs:
164164
run: |
165165
# Setup IJulia with the jupyter from the Python environment
166166
# https://julialang.github.io/IJulia.jl/stable/manual/installation/
167-
export JUPYTER=$(find $(dirname $(pipenv run which jupyter))/ -type f -name "jupyter.exe" -o -name "jupyter")
167+
export JUPYTER=$(find $(dirname $(pipenv run which jupyter))/ -type f -name "jupyter.exe" -o -name "jupyter")
168168
pipenv run julia --color=yes --project=. -e "import Pkg; Pkg.instantiate(); Pkg.build(\"IJulia\"); Pkg.precompile()"
169169
echo "Julia Jupyter:"
170170
julia --project=. -e "import IJulia;println(IJulia.JUPYTER);println(IJulia.find_jupyter_subcommand(\"notebook\"))"
@@ -174,6 +174,9 @@ jobs:
174174
run: |
175175
echo "QUARTO_TEST_TIMING=timing-for-ci.txt" >> "$GITHUB_ENV"
176176
177+
# - name: Setup tmate session
178+
# uses: mxschmitt/action-tmate@v3
179+
177180
- name: Run all Smoke Tests Windows
178181
if: ${{ runner.os == 'Windows' && format('{0}', inputs.buckets) == '' && matrix.time-test == false }}
179182
env:
@@ -197,6 +200,7 @@ jobs:
197200
env:
198201
# Useful as TinyTeX latest release is checked in run-test.sh
199202
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
203+
QUARTO_LOG_LEVEL: DEBUG
200204
run: |
201205
haserror=0
202206
readarray -t my_array < <(echo '${{ inputs.buckets }}' | jq -rc '.[]')

src/execute/engine.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ import { mergeConfigs } from "../core/config.ts";
2929
import { ProjectContext } from "../project/types.ts";
3030
import { pandocBuiltInFormats } from "../core/pandoc/pandoc-formats.ts";
3131
import { gitignoreEntries } from "../project/project-gitignore.ts";
32+
import { juliaEngine } from "./julia.ts";
3233

3334
const kEngines: Map<string, ExecutionEngine> = new Map();
3435

@@ -40,7 +41,9 @@ export function executionEngine(name: string) {
4041
return kEngines.get(name);
4142
}
4243

43-
for (const engine of [knitrEngine, jupyterEngine, markdownEngine]) {
44+
for (
45+
const engine of [knitrEngine, jupyterEngine, markdownEngine, juliaEngine]
46+
) {
4447
registerExecutionEngine(engine);
4548
}
4649

0 commit comments

Comments
 (0)