Skip to content

Commit 42aea7b

Browse files
the-thingthe-thing
committed
QFJ-375 - replaced heartbeat timeout multiplier magic number with default value in unit test
1 parent de4a975 commit 42aea7b

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

‎quickfixj-core/src/test/java/quickfix/SessionTest.java‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public void testDisposalOfFileResources() throws Exception {
101101
new DefaultMessageFactory(), 30, false, 30, UtcTimestampPrecision.MILLIS, true, false,
102102
false, false, false, false, true, false, 1.5, null, true,
103103
new int[] { 5 }, false, false, false, false, true, false, true, false,
104-
null, true, 0, false, false, true, new ArrayList<>(), 1.4)) {
104+
null, true, 0, false, false, true, new ArrayList<>(), Session.DEFAULT_HEARTBEAT_TIMEOUT_MULTIPLIER)) {
105105
// Simulate socket disconnect
106106
session.setResponder(null);
107107
}
@@ -142,7 +142,7 @@ public void testNondisposableFileResources() throws Exception {
142142
new DefaultMessageFactory(), 30, false, 30, UtcTimestampPrecision.MILLIS, true, false,
143143
false, false, false, false, true, false, 1.5, null, true,
144144
new int[] { 5 }, false, false, false, false, true, false, true, false,
145-
null, true, 0, false, false, true, new ArrayList<>(), 1.4)) {
145+
null, true, 0, false, false, true, new ArrayList<>(), Session.DEFAULT_HEARTBEAT_TIMEOUT_MULTIPLIER)) {
146146
// Simulate socket disconnect
147147
session.setResponder(null);
148148

@@ -2074,7 +2074,7 @@ private void testSequenceResetGapFillWithChunkSize(int chunkSize)
20742074
UtcTimestampPrecision.MILLIS, resetOnLogon, false, false, false, false, false, true,
20752075
false, 1.5, null, validateSequenceNumbers, new int[] { 5 },
20762076
false, false, false, false, true, false, true, false, null, true,
2077-
chunkSize, false, false, true, new ArrayList<>(), 1.4)) {
2077+
chunkSize, false, false, true, new ArrayList<>(), Session.DEFAULT_HEARTBEAT_TIMEOUT_MULTIPLIER)) {
20782078

20792079
UnitTestResponder responder = new UnitTestResponder();
20802080
session.setResponder(responder);
@@ -2136,7 +2136,7 @@ public void correct_sequence_number_for_last_gap_fill_if_next_sender_sequence_nu
21362136
new DefaultMessageFactory(), 30, false, 30, UtcTimestampPrecision.MILLIS, resetOnLogon,
21372137
false, false, false, false, false, true, false, 1.5, null, validateSequenceNumbers,
21382138
new int[]{5}, false, false, false, false, true, false, true, false, null, true, 0,
2139-
false, false, true, new ArrayList<>(), 1.4);
2139+
false, false, true, new ArrayList<>(), Session.DEFAULT_HEARTBEAT_TIMEOUT_MULTIPLIER);
21402140

21412141
Responder mockResponder = mock(Responder.class);
21422142
when(mockResponder.send(anyString())).thenReturn(true);
@@ -2184,7 +2184,7 @@ public void correct_sequence_number_for_last_gap_fill_if_next_sender_sequence_nu
21842184
new DefaultMessageFactory(), 30, false, 30, UtcTimestampPrecision.MILLIS, resetOnLogon,
21852185
false, false, false, false, false, true, false, 1.5, null, validateSequenceNumbers,
21862186
new int[]{5}, false, false, false, false, true, false, true, false, null, true, 0,
2187-
enableNextExpectedMsgSeqNum, false, true, new ArrayList<>(), 1.4);
2187+
enableNextExpectedMsgSeqNum, false, true, new ArrayList<>(), Session.DEFAULT_HEARTBEAT_TIMEOUT_MULTIPLIER);
21882188

21892189
Responder mockResponder = mock(Responder.class);
21902190
when(mockResponder.send(anyString())).thenReturn(true);
@@ -2233,7 +2233,7 @@ public void testMsgSeqNumTooHighWithDisconnectOnError() throws Exception {
22332233
UtcTimestampPrecision.MILLIS, resetOnLogon, false, false, false, false, false, true,
22342234
false, 1.5, null, validateSequenceNumbers, new int[] { 5 },
22352235
false, disconnectOnError, false, false, true, false, true, false,
2236-
null, true, 0, false, false, true, new ArrayList<>(), 1.4)) {
2236+
null, true, 0, false, false, true, new ArrayList<>(), Session.DEFAULT_HEARTBEAT_TIMEOUT_MULTIPLIER)) {
22372237

22382238
UnitTestResponder responder = new UnitTestResponder();
22392239
session.setResponder(responder);
@@ -2269,7 +2269,7 @@ public void testTimestampPrecision() throws Exception {
22692269
UtcTimestampPrecision.NANOS, resetOnLogon, false, false, false, false, false, true,
22702270
false, 1.5, null, validateSequenceNumbers, new int[] { 5 },
22712271
false, disconnectOnError, false, false, true, false, true, false,
2272-
null, true, 0, false, false, true, new ArrayList<>(), 1.4)) {
2272+
null, true, 0, false, false, true, new ArrayList<>(), Session.DEFAULT_HEARTBEAT_TIMEOUT_MULTIPLIER)) {
22732273

22742274
UnitTestResponder responder = new UnitTestResponder();
22752275
session.setResponder(responder);
@@ -2321,7 +2321,7 @@ private void testLargeQueue(int N) throws Exception {
23212321
new DefaultMessageFactory(), isInitiator ? 30 : 0, false, 30, UtcTimestampPrecision.MILLIS, resetOnLogon,
23222322
false, false, false, false, false, true, false, 1.5, null, validateSequenceNumbers,
23232323
new int[]{5}, false, false, false, false, true, false, true, false, null, true, 0,
2324-
false, false, true, new ArrayList<>(), 1.4);
2324+
false, false, true, new ArrayList<>(), Session.DEFAULT_HEARTBEAT_TIMEOUT_MULTIPLIER);
23252325

23262326
UnitTestResponder responder = new UnitTestResponder();
23272327
session.setResponder(responder);
@@ -2437,7 +2437,7 @@ public void fromAdmin(Message message, SessionID sessionId) throws FieldNotFound
24372437
new DefaultMessageFactory(), isInitiator ? 30 : 0, false, 30, UtcTimestampPrecision.MILLIS, resetOnLogon,
24382438
false, false, false, false, false, true, false, 1.5, null, validateSequenceNumbers,
24392439
new int[]{5}, false, false, false, false, true, false, true, false, null, true, 0,
2440-
enableNextExpectedMsgSeqNum, false, true, new ArrayList<>(), 1.4);
2440+
enableNextExpectedMsgSeqNum, false, true, new ArrayList<>(), Session.DEFAULT_HEARTBEAT_TIMEOUT_MULTIPLIER);
24412441
UnitTestResponder responder = new UnitTestResponder();
24422442
session.setResponder(responder);
24432443

0 commit comments

Comments
 (0)