Skip to content

Move sleepycat code out of quickfixj-core #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
philipwhiuk opened this issue Jan 6, 2022 · 2 comments
Open

Move sleepycat code out of quickfixj-core #459

philipwhiuk opened this issue Jan 6, 2022 · 2 comments
Assignees
Milestone

Comments

@philipwhiuk
Copy link
Contributor

philipwhiuk commented Jan 6, 2022

Sleepycat seems unmaintained. Depending on sleepycat involves including an extra database implementation that (most?) people probably aren't using.

To my knowledge this only affects quickfix.SleepycatStore and quickfix.SleepycatStoreFactory

Options:

  1. Extract Sleepycat code to quickfixj-sleepycat which depends on quickfixj-core. Breaking change for Sleepycat Store users, no impact on everyone else.

  2. Just remove Sleepycat code. Would mean any Sleepycat Store users have to copy in the code to their own projects and maintain it separately. Completely removes QuickfixJ's dependency on it.

@philipwhiuk philipwhiuk changed the title Move sleepycat code to quickfix-sleepycat Move sleepycat code out of quickfixj-core Jan 7, 2022
@chrjohn
Copy link
Member

chrjohn commented Jan 27, 2022

I think option 1 would be the way to go. But I also don't have any insight into how much Sleepycat is used.
Also see #449 which might be related w.r.t. creating a new submodule.

@david-gibbs-ig
Copy link
Contributor

If I may express an opinion on this I think that changing the publishing of SleepycatStore can be regarded as a breaking change, but only in the sense of requiring a new dependency. For higher backwards compatibility the package names could remain the same, but the new module can build and test it. It can even be moved from the existing repo into its own repo in a release such as 3.0.0. It would depend on quickfixj-core. You could leave it unmaintained and wait to see if anyone requests that it be maintained to track qfj releases. If not then it can at some point be deprecated.

@chrjohn chrjohn self-assigned this Feb 2, 2023
@chrjohn chrjohn added this to the QFJ 3.0.0 milestone Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants