Skip to content

Commit b1d8d9b

Browse files
author
Christoph Russ
committed
Fix issue plotly#300: changing pagination button text
1 parent 0d6b7c4 commit b1d8d9b

File tree

13 files changed

+22
-23
lines changed

13 files changed

+22
-23
lines changed

dash_table/DataTable.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ class DataTable(Component):
313313
- page_action (a value equal to: 'custom', 'native', 'none'; optional): `page_action` refers to a mode of the table where
314314
not all of the rows are displayed at once: only a subset
315315
are displayed (a "page") and the next subset of rows
316-
can viewed by clicking "Next" or "Previous" buttons
316+
can viewed by clicking "<" (previous) or ">" (next) buttons
317317
at the bottom of the page.
318318
319319
Pagination is used to improve performance: instead of
@@ -323,7 +323,7 @@ class DataTable(Component):
323323
With pagination, we can either page through data that exists
324324
in the table (e.g. page through `10,000` rows in `data` `100` rows at a time)
325325
or we can update the data on-the-fly with callbacks
326-
when the user clicks on the "Previous" or "Next" buttons.
326+
when the user clicks on the "<" (previous) or ">" (next) buttons.
327327
These modes can be toggled with this `page_action` parameter:
328328
- `'native'`: all data is passed to the table up-front, paging logic is
329329
handled by the table

dash_table/bundle.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dash_table/bundle.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dash_table/demo.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dash_table/demo.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dash_table/metadata.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -750,7 +750,7 @@
750750
]
751751
},
752752
"required": false,
753-
"description": "`page_action` refers to a mode of the table where\nnot all of the rows are displayed at once: only a subset\nare displayed (a \"page\") and the next subset of rows\ncan viewed by clicking \"Next\" or \"Previous\" buttons\nat the bottom of the page.\n\nPagination is used to improve performance: instead of\nrendering all of the rows at once (which can be expensive),\nwe only display a subset of them.\n\nWith pagination, we can either page through data that exists\nin the table (e.g. page through `10,000` rows in `data` `100` rows at a time)\nor we can update the data on-the-fly with callbacks\nwhen the user clicks on the \"Previous\" or \"Next\" buttons.\nThese modes can be toggled with this `page_action` parameter:\n- `'native'`: all data is passed to the table up-front, paging logic is\nhandled by the table\n- `'custom'`: data is passed to the table one page at a time, paging logic\nis handled via callbacks\n- `none`: disables paging, render all of the data at once",
753+
"description": "`page_action` refers to a mode of the table where\nnot all of the rows are displayed at once: only a subset\nare displayed (a \"page\") and the next subset of rows\ncan viewed by clicking \"<\" (previous) or \">\" (next) buttons\nat the bottom of the page.\n\nPagination is used to improve performance: instead of\nrendering all of the rows at once (which can be expensive),\nwe only display a subset of them.\n\nWith pagination, we can either page through data that exists\nin the table (e.g. page through `10,000` rows in `data` `100` rows at a time)\nor we can update the data on-the-fly with callbacks\nwhen the user clicks on the \"<\" (previous) or \">\" (next) buttons.\nThese modes can be toggled with this `page_action` parameter:\n- `'native'`: all data is passed to the table up-front, paging logic is\nhandled by the table\n- `'custom'`: data is passed to the table one page at a time, paging logic\nis handled via callbacks\n- `none`: disables paging, render all of the data at once",
754754
"defaultValue": {
755755
"value": "'native'",
756756
"computed": false
@@ -1757,4 +1757,4 @@
17571757
}
17581758
}
17591759
}
1760-
}
1760+
}

inst/deps/bundle.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

inst/deps/bundle.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

inst/deps/demo.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

inst/deps/demo.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/dashDataTable.Rd

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ and not have borders between the columns.}
361361
\item{pagination_mode}{A value equal to: 'fe', 'be', true, false. "pagination" refers to a mode of the table where
362362
not all of the rows are displayed at once: only a subset
363363
are displayed (a "page") and the next subset of rows
364-
can viewed by clicking "Next" or "Previous" buttons
364+
can viewed by clicking "<" (previous) or ">" (next) buttons
365365
at the bottom of the page.
366366

367367
Pagination is used to improve performance: instead of
@@ -371,7 +371,7 @@ we only display a subset of them.
371371
With pagination, we can either page through data that exists
372372
in the table (e.g. page through `10,000` rows in `data` `100` rows at a time)
373373
or we can update the data on-the-fly with callbacks
374-
when the user clicks on the "Previous" or "Next" buttons.
374+
when the user clicks on the "<" (previous) or ">" (next) buttons.
375375
These modes can be toggled with this `pagination_mode` parameter:
376376
- `'fe'` refers to "front-end" paging: passing large data up-front
377377
- `'be'` refers to "back-end" paging: updating the data on the fly via callbacks
@@ -759,4 +759,3 @@ across all pages.}
759759
Subscribe to [https://github.com/plotly/dash-table/issues/168](https://github.com/plotly/dash-table/issues/168)
760760
for updates on the dropdown API.}
761761
}
762-

src/dash-table/components/ControlledTable/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -796,8 +796,8 @@ export default class ControlledTable extends PureComponent<ControlledTableProps>
796796
</div>
797797
{!this.displayPagination ? null : (
798798
<div>
799-
<button className='previous-page' onClick={this.loadPrevious}>Previous</button>
800-
<button className='next-page' onClick={this.loadNext}>Next</button>
799+
<button className='previous-page' onClick={this.loadPrevious}><</button>
800+
<button className='next-page' onClick={this.loadNext}>></button>
801801
</div>
802802
)}
803803
</div>);

src/dash-table/dash/DataTable.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,7 @@ export const propTypes = {
557557
* `page_action` refers to a mode of the table where
558558
* not all of the rows are displayed at once: only a subset
559559
* are displayed (a "page") and the next subset of rows
560-
* can viewed by clicking "Next" or "Previous" buttons
560+
* can viewed by clicking "<" (previous) or ">" (next) buttons
561561
* at the bottom of the page.
562562
*
563563
* Pagination is used to improve performance: instead of
@@ -567,7 +567,7 @@ export const propTypes = {
567567
* With pagination, we can either page through data that exists
568568
* in the table (e.g. page through `10,000` rows in `data` `100` rows at a time)
569569
* or we can update the data on-the-fly with callbacks
570-
* when the user clicks on the "Previous" or "Next" buttons.
570+
* when the user clicks on the "<" (previous) or ">" (next) buttons.
571571
* These modes can be toggled with this `page_action` parameter:
572572
* - `'native'`: all data is passed to the table up-front, paging logic is
573573
* handled by the table

0 commit comments

Comments
 (0)