Release zip 2.1.0

[gaborcsardi]

Prepare for release:

• devtools::check_win_devel() seems dead
• rhub::check_for_cran()
• rhub::check(platform = "solaris-x86-patched")
• rhub::check(platform = "ubuntu-rchk")
• revdepcheck::revdep_check(num_workers = 4)
• Polish NEWS
• If new failures, update email.yml then revdepcheck::revdep_email_maintainers()

Perform release:

• Bump version (in DESCRIPTION and NEWS)
• devtools::submit_cran()
• Approve email

Wait for CRAN...

• Tag release
• Bump dev version

Template from r-lib/usethis#338

[gaborcsardi]

@davidgohel This should not break anything (although I haven't run the revdep checks yet), but I had to rewrite a lot of code for Unicode support so you might want to test officer with this. Thanks!

[davidgohel]

thanks - I did a quick test on a colleague Windows machine, so far everything looks ok.
I will do more tests tomorrow and let you know if something broke

[davidgohel]

Funny, I did that fix yesterday: davidgohel/officer@8c7926b

From your code, I understand I should have used first enc2utf8, then Encoding(blah) <- "UTF-8"? (ignore my question if no time...)

[gaborcsardi]

It depends what target is in your code. E.g. if it is a path from the zip file, then it is already UTF-8. Well, it is in the new version, if the zip file was created by zip.

[davidgohel]

@gaborcsardi OK, thanks for having worked on that

[davidgohel]

Hi,

A quick confirmation, the new version is working well and is solving issues with Windows paths or filename containing non ascii characters

[gaborcsardi]

@davidgohel Great, thanks!