Skip to content

Commit d2634d1

Browse files
committed
increase units version dep; units init stuff
1 parent 8f92f46 commit d2634d1

File tree

4 files changed

+11
-36
lines changed

4 files changed

+11
-36
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Imports:
2525
grid,
2626
Rcpp,
2727
DBI (>= 0.8),
28-
units (>= 0.5-1),
28+
units (>= 0.6-0),
2929
classInt,
3030
magrittr
3131
Suggests:

R/crs.R

Lines changed: 8 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -210,32 +210,9 @@ st_is_longlat = function(x) {
210210
}
211211

212212
# a = "b" => a is the proj.4 unit (try: cs2cs -lu); "b" is the udunits2 unit
213-
udunits_from_proj = if (utils::packageVersion("units") < "0.5-2") {
213+
udunits_from_proj = list(
214214
# PROJ.4 UDUNITS
215-
c( `km` = "km",
216-
`m` = "m",
217-
`dm` = "dm",
218-
`cm` = "cm",
219-
`mm` = "mm",
220-
`kmi` = "nautical_mile",
221-
`in` = "in",
222-
`ft` = "ft",
223-
`yd` = "yd",
224-
`mi` = "mi",
225-
`fath` = "fathom",
226-
`ch` = "chain",
227-
# `link` = "0.201168 m",
228-
# `us-in` = "1./39.37 m",
229-
`us-ft` = "US_survey_foot",
230-
`us-yd` = "US_survey_yard",
231-
`us-ch` = "chain",
232-
`us-mi` = "US_survey_mile"
233-
# `ind-yd` = "0.91439523 m",
234-
# `ind-ft` = "0.30479841 m",
235-
# `ind-ch` = "20.11669506 m"
236-
)
237-
} else {
238-
list(`km` = as_units("km"),
215+
`km` = as_units("km"),
239216
`m` = as_units("m"),
240217
`dm` = as_units("dm"),
241218
`cm` = as_units("cm"),
@@ -247,17 +224,16 @@ list(`km` = as_units("km"),
247224
`mi` = as_units("mi"),
248225
`fath` = as_units("fathom"),
249226
`ch` = as_units("chain"),
250-
# `link` = as_units("link"),
251-
# `us-in` = as_units("us_in"),
227+
`link` = as_units("link", check_is_valid = FALSE), # not (yet) existing; set in .onLoad()
228+
`us-in` = as_units("us_in", check_is_valid = FALSE),
252229
`us-ft` = as_units("US_survey_foot"),
253230
`us-yd` = as_units("US_survey_yard"),
254231
`us-ch` = as_units("chain"),
255-
`us-mi` = as_units("US_survey_mile")
256-
# `ind-yd` = as_units("ind_yd"),
257-
# `ind-ft` = as_units("ind_ft"),
258-
# `ind-ch` = as_units("ind_ch")
232+
`us-mi` = as_units("US_survey_mile"),
233+
`ind-yd` = as_units("ind_yd", check_is_valid = FALSE),
234+
`ind-ft` = as_units("ind_ft", check_is_valid = FALSE),
235+
`ind-ch` = as_units("ind_ch", check_is_valid = FALSE)
259236
)
260-
}
261237

262238
crs_parameters = function(x) {
263239
stopifnot(!is.na(x))

R/init.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ setOldClass("sfg")
4141
}
4242
CPL_gdal_init()
4343
register_all_s3_methods() # dynamically registers non-imported pkgs (tidyverse)
44-
#units::install_conversion_constant("m", "link", 0.201168)
44+
units::install_conversion_constant("m", "link", 0.201168)
4545
#units::install_conversion_constant("m", "us_in", 1./39.37)
4646
#units::install_conversion_constant("m", "ind_yd", 0.91439523)
4747
#units::install_conversion_constant("m", "ind_ft", 0.30479841)
@@ -56,7 +56,7 @@ setOldClass("sfg")
5656
Sys.setenv("GDAL_DATA"=get(".sf.GDAL_DATA", envir=.sf_cache))
5757
# nocov end
5858
}
59-
#units::remove_symbolic_unit("link")
59+
units::remove_symbolic_unit("link")
6060
#units::remove_symbolic_unit("us_in")
6161
#units::remove_symbolic_unit("ind_yd")
6262
#units::remove_symbolic_unit("ind_ft")

tests/testthat/test_gdal.R

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ test_that("st_transform works", {
3434

3535
test_that("gdal can be loaded, unloaded, and loaded", {
3636
expect_silent({
37-
sf:::.onLoad()
3837
sf:::.onUnload()
3938
sf:::.onLoad()
4039
}

0 commit comments

Comments
 (0)