Moved tests

Author: aidanharan

test/cases/fetch_test_sqlserver.rb

@@ -2,8 +2,11 @@
 
 require "cases/helper_sqlserver"
 require "models/book"
+require "models/post"
 
 class FetchTestSqlserver < ActiveRecord::TestCase
+  fixtures :posts
+
   let(:books) { @books }
 
   before { create_10_books }
@@ -59,6 +62,74 @@ class FetchTestSqlserver < ActiveRecord::TestCase
         query.to_sql
       end
     end
+
+    it "order by the provided orderings" do
+      sql = "SELECT sum(legacy_comments_count), count(*), min(legacy_comments_count) FROM (SELECT [posts].[legacy_comments_count] FROM [posts] ORDER BY [posts].[legacy_comments_count] DESC OFFSET 0 ROWS FETCH NEXT @0 ROWS ONLY) subquery ORDER BY sum(legacy_comments_count) ASC OFFSET 0 ROWS FETCH NEXT @1 ROWS ONLY"
+
+      assert_queries_match(/#{Regexp.escape(sql)}/) do
+        result = Post.from(Post.order(legacy_comments_count: :desc).limit(5).select(:legacy_comments_count)).pick(Arel.sql("sum(legacy_comments_count), count(*), min(legacy_comments_count)"))
+        assert_equal result, [11, 5, 1]
+      end
+    end
+
+    it "in subquery order by first projection if no order provided" do
+      sql = "SELECT sum(legacy_comments_count), count(*), min(legacy_comments_count) FROM (SELECT [posts].[legacy_comments_count], [posts].[tags_count] FROM [posts] ORDER BY [posts].[id] ASC OFFSET 0 ROWS FETCH NEXT @0 ROWS ONLY) subquery ORDER BY sum(legacy_comments_count) ASC OFFSET 0 ROWS FETCH NEXT @1 ROWS ONLY"
+
+      assert_queries_match(/#{Regexp.escape(sql)}/) do
+        result = Post.from(Post.limit(5).select(:legacy_comments_count, :tags_count)).pick(Arel.sql("sum(legacy_comments_count), count(*), min(legacy_comments_count)"))
+        assert_equal result, [10, 5, 0]
+      end
+    end
+
+    it "in subquery order by primary key if no projections and order provided" do
+      sql = "SELECT sum(legacy_comments_count), count(*), min(legacy_comments_count) FROM (SELECT [posts].* FROM [posts] ORDER BY [posts].[id] ASC OFFSET 0 ROWS FETCH NEXT @0 ROWS ONLY) subquery ORDER BY sum(legacy_comments_count) ASC OFFSET 0 ROWS FETCH NEXT @1 ROWS ONLY"
+
+      assert_queries_match(/#{Regexp.escape(sql)}/) do
+        result = Post.from(Post.limit(5)).pick(Arel.sql("sum(legacy_comments_count), count(*), min(legacy_comments_count)"))
+        assert_equal result, [10, 5, 0]
+      end
+    end
+  end
+
+  describe "GROUP query" do
+    it "order by primary key if not a GROUP query" do
+      assert_queries_match(/#{Regexp.escape("ORDER BY [posts].[id] ASC")}/i) do
+        Post.pick(:title)
+      end
+    end
+
+    it "invalid SQL generated by `find_nth_with_limit` adding primary key ordering" do
+      error = assert_raises(ActiveRecord::StatementInvalid) do
+        Post.select(:title, "count(*)").group(:title).first(2)
+      end
+      assert_match(/Column "posts\.id" is invalid in the ORDER BY clause/, error.message)
+    end
+
+    it "valid SQL generated if order specified" do
+      assert_queries_match(/#{Regexp.escape("SELECT [posts].[title], count(*) FROM [posts] GROUP BY [posts].[title] ORDER BY [posts].[title]")}/i) do
+        Post.select(:title, "count(*)").group(:title).order(:title).first(2)
+      end
+    end
+  end
+
+  describe "LIMIT query" do
+    it "order by primary key if no projections" do
+      sql = Post.limit(5).to_sql
+
+      assert_equal "SELECT [posts].* FROM [posts] ORDER BY [posts].[id] ASC OFFSET 0 ROWS FETCH NEXT 5 ROWS ONLY", sql
+    end
+
+    it "order by primary key if projections and no order provided" do
+      sql = Post.select(:legacy_comments_count).limit(5).to_sql
+
+      assert_equal "SELECT [posts].[legacy_comments_count] FROM [posts] ORDER BY [posts].[id] ASC OFFSET 0 ROWS FETCH NEXT 5 ROWS ONLY", sql
+    end
+
+    it "use order provided" do
+      sql = Post.select(:legacy_comments_count).order(:tags_count).limit(5).to_sql
+
+      assert_equal "SELECT [posts].[legacy_comments_count] FROM [posts] ORDER BY [posts].[tags_count] ASC OFFSET 0 ROWS FETCH NEXT 5 ROWS ONLY", sql
+    end
   end
 
   protected