You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
jquery-rails is work of [many contributors](https://github.com/rails/jquery-rails/graphs/contributors). You're encouraged to submit [pull requests](https://github.com/rails/jquery-rails/pulls), [propose features and discuss issues](https://github.com/rails/jquery-rails/issues).
7
+
8
+
#### Updating jQuery
6
9
7
10
If the jquery or jquery-ui scripts are outdated (i.e. maybe a new version of jquery was released yesterday), feel free to open an issue and prod us to get that thing updated. However, for security reasons, we won't be accepting pull requests with updated jquery or jquery-ui scripts.
8
11
9
-
## Changes to jquery_ujs.js
12
+
####Changes to jquery_ujs.js
10
13
11
14
**If it's an issue pertaining to the jquery-ujs javascript, please
12
15
report it to the [rails/jquery-ujs project](https://github.com/rails/jquery-ujs/issues).**
13
16
14
-
## Tests
17
+
#### Fork the Project
18
+
19
+
Fork the [project on Github](https://github.com/rails/jquery-rails) and check out your copy.
Writing good commit logs is important. A commit log should describe what changed and why.
96
+
97
+
```
98
+
git add ...
99
+
git commit
100
+
```
101
+
102
+
#### Push
103
+
104
+
```
105
+
git push origin my-feature-branch
106
+
```
107
+
108
+
#### Make a Pull Request
109
+
110
+
Go to https://github.com/contributor/jquery-rails and select your feature branch. Click the 'Pull Request' button and fill out the form. Pull requests are usually reviewed within a few days.
111
+
112
+
#### Rebase
113
+
114
+
If you've been working on a change for a while, rebase with upstream/master.
115
+
116
+
```
117
+
git fetch upstream
118
+
git rebase upstream/master
119
+
git push origin my-feature-branch -f
120
+
```
121
+
122
+
#### Check on Your Pull Request
123
+
124
+
Go back to your pull request after a few minutes and see whether it passed muster with Travis-CI. Everything should look green, otherwise fix issues and amend your commit as described above.
125
+
126
+
#### Be Patient
127
+
128
+
It's likely that your change will not be merged and that the nitpicky maintainers will ask you to do more, or fix seemingly benign problems. Hang on there!
129
+
130
+
#### Thank You
131
+
132
+
Please do know that we really appreciate and value your time and work. We love you, really.
Copy file name to clipboardExpand all lines: README.md
+8-4Lines changed: 8 additions & 4 deletions
Original file line number
Diff line number
Diff line change
@@ -43,16 +43,20 @@ For jQuery UI, we recommend the [jquery-ui-rails](https://github.com/joliss/jque
43
43
*As of v3.0, jquery-rails no longer includes jQuery UI. Use the
44
44
jquery-ui-rails gem above.*
45
45
46
-
## Contributing
46
+
## Contributing to jquery-rails
47
47
48
-
Feel free to open an issue ticket if you find something that could be improved. A couple notes:
48
+
jquery-rails is work of many contributors. You're encouraged to submit pull requests, propose
49
+
features and discuss issues.
49
50
50
51
* If it's an issue pertaining to the jquery-ujs javascript, please report it to the [jquery-ujs project](https://github.com/rails/jquery-ujs).
51
52
52
53
* If the jQuery scripts are outdated (i.e. maybe a new version of jquery was released yesterday), feel free to open an issue and prod us to get that thing updated. However, for security reasons, we won't be accepting pull requests with updated jQuery scripts.
53
54
55
+
See [CONTRIBUTING](CONTRIBUTING.md).
56
+
57
+
## License
58
+
jquery-rails is released under the [MIT License](MIT-LICENSE).
59
+
54
60
## Acknowledgements
55
61
56
62
Many thanks are due to all of [the jquery-rails contributors](https://github.com/rails/jquery-rails/graphs/contributors). Special thanks to [JangoSteve](http://github.com/JangoSteve) for tirelessly answering questions and accepting patches, and the [Rails Core Team](https://github.com/organizations/rails/teams/617) for making jquery-rails an official part of Rails 3.1.
57
-
58
-
Copyright [André Arko](http://arko.net), released under the MIT License.
0 commit comments