Fix image_pack_tag to find images under by default

Author: guilleiguaran

lib/webpacker/helper.rb

@@ -142,7 +142,7 @@ def sources_from_manifest_entrypoints(names, type:)
     end
 
     def resolve_path_to_image(name)
-      path = name.starts_with?("media/") ? name : "media/#{name}"
+      path = name.starts_with?("media/images/") ? name : "media/images/#{name}"
       asset_path(current_webpacker_instance.manifest.lookup!(path))
     rescue
       asset_path(current_webpacker_instance.manifest.lookup!(name))

test/helper_test.rb

@@ -39,11 +39,17 @@ def test_image_pack_tag
       "<img alt=\"Edit Entry\" src=\"/packs/application-k344a6d59eef8632c9d1.png\" width=\"16\" height=\"10\" />",
       image_pack_tag("application.png", size: "16x10", alt: "Edit Entry")
     assert_equal \
-      "<img alt=\"Edit Entry\" src=\"/packs/media/image-c38deda30895059837cf.jpg\" width=\"16\" height=\"10\" />",
+      "<img alt=\"Edit Entry\" src=\"/packs/media/images/image-c38deda30895059837cf.jpg\" width=\"16\" height=\"10\" />",
       image_pack_tag("image.jpg", size: "16x10", alt: "Edit Entry")
     assert_equal \
-      "<img alt=\"Edit Entry\" src=\"/packs/media/image-c38deda30895059837cf.jpg\" width=\"16\" height=\"10\" />",
-      image_pack_tag("media/image.jpg", size: "16x10", alt: "Edit Entry")
+      "<img alt=\"Edit Entry\" src=\"/packs/media/images/image-c38deda30895059837cf.jpg\" width=\"16\" height=\"10\" />",
+      image_pack_tag("media/images/image.jpg", size: "16x10", alt: "Edit Entry")
+    assert_equal \
+      "<img alt=\"Edit Entry\" src=\"/packs/media/images/nested/image-c38deda30895059837cf.jpg\" width=\"16\" height=\"10\" />",
+      image_pack_tag("nested/image.jpg", size: "16x10", alt: "Edit Entry")
+    assert_equal \
+      "<img alt=\"Edit Entry\" src=\"/packs/media/images/nested/image-c38deda30895059837cf.jpg\" width=\"16\" height=\"10\" />",
+      image_pack_tag("media/images/nested/image.jpg", size: "16x10", alt: "Edit Entry")
   end
 
   def test_javascript_pack_tag

test/test_app/public/packs/manifest.json

@@ -4,7 +4,8 @@
   "bootstrap.js": "/packs/bootstrap-300631c4f0e0f9c865bc.js",
   "application.js": "/packs/application-k344a6d59eef8632c9d1.js",
   "application.png": "/packs/application-k344a6d59eef8632c9d1.png",
-  "media/image.jpg": "/packs/media/image-c38deda30895059837cf.jpg",
+  "media/images/image.jpg": "/packs/media/images/image-c38deda30895059837cf.jpg",
+  "media/images/nested/image.jpg": "/packs/media/images/nested/image-c38deda30895059837cf.jpg",
   "entrypoints": {
     "application": {
       "js": [