Use a separate env file to define NODE_ENV

Remove redundant assign

Fix comment

Fix sentence

Author: gauravtiwari

lib/tasks/webpacker/compile.rake

@@ -1,11 +1,12 @@
+require "webpacker/env"
 require "webpacker/configuration"
 REGEX_MAP = /\A.*\.map\z/
 
 namespace :webpacker do
   desc "Compile javascript packs using webpack for production with digests"
   task compile: ["webpacker:verify_install", :environment] do
     puts "Compiling webpacker assets 🎉"
-    result = `NODE_ENV=#{ENV["NODE_ENV"] || "production"} ./bin/webpack`
+    result = `NODE_ENV=#{Webpacker::Env.current} ./bin/webpack`
 
     unless $?.success?
       puts JSON.parse(result)["errors"]

lib/webpacker/configuration.rb

@@ -1,5 +1,6 @@
 # Loads webpacker configuration from config/webpack/paths.yml
 require "webpacker/file_loader"
+require "webpacker/env"
 
 class Webpacker::Configuration < Webpacker::FileLoader
   class << self
@@ -24,7 +25,7 @@ def output_path
     end
 
     def paths
-      load if ENV["NODE_ENV"] == "development"
+      load if Webpacker::Env.development?
       raise Webpacker::FileLoader::FileLoaderError.new("Webpacker::Configuration.load must be called first") unless instance
       instance.data
     end
@@ -37,6 +38,6 @@ def source_path
   private
     def load
       return super unless File.exist?(@path)
-      HashWithIndifferentAccess.new(YAML.load(File.read(@path))[ENV["NODE_ENV"]])
+      HashWithIndifferentAccess.new(YAML.load(File.read(@path))[Webpacker::Env.current])
     end
 end

lib/webpacker/env.rb

@@ -0,0 +1,27 @@
+# Singleton registry for determining NODE_ENV from config/webpack/paths.yml
+require "webpacker/file_loader"
+
+class Webpacker::Env < Webpacker::FileLoader
+  class << self
+    def current
+      raise Webpacker::FileLoader::FileLoaderError.new("Webpacker::Env.load must be called first") unless instance
+      instance.data
+    end
+
+    def development?
+      current == "development"
+    end
+
+    def file_path
+      Rails.root.join("config", "webpack", "paths.yml")
+    end
+  end
+
+  private
+    def load
+      environments = File.exist?(@path) ? YAML.load(File.read(@path)).keys : [].freeze
+      return ENV["NODE_ENV"] if environments.include?(ENV["NODE_ENV"])
+      return Rails.env if environments.include?(Rails.env)
+      "production"
+    end
+end

lib/webpacker/manifest.rb

@@ -6,6 +6,7 @@
 # "/packs/calendar-1016838bab065ae1e314.css" for long-term caching
 
 require "webpacker/file_loader"
+require "webpacker/env"
 require "webpacker/configuration"
 
 class Webpacker::Manifest < Webpacker::FileLoader
@@ -15,7 +16,7 @@ def file_path
     end
 
     def lookup(name)
-      load if ENV["NODE_ENV"] == "development"
+      load if Webpacker::Env.development?
       raise Webpacker::FileLoader::FileLoaderError.new("Webpacker::Manifest.load must be called first") unless instance
       instance.data[name.to_s] || raise(Webpacker::FileLoader::NotFoundError.new("Can't find #{name} in #{file_path}. Is webpack still compiling?"))
     end

lib/webpacker/railtie.rb

@@ -1,16 +1,16 @@
 require "rails/railtie"
 
 require "webpacker/helper"
+require "webpacker/env"
 
 class Webpacker::Engine < ::Rails::Engine
   initializer :webpacker do |app|
     ActiveSupport.on_load :action_controller do
       ActionController::Base.helper Webpacker::Helper
     end
 
-    # Use NODE_ENV if defined, else fallback to RAILS_ENV
-    ENV["NODE_ENV"] ||= ENV["RAILS_ENV"]
-
+    # Setup NODE_ENV environment based on config/webpack/paths.yml
+    Webpacker::Env.load
     # Loads webpacker config data from config/webpack/paths.yml
     Webpacker::Configuration.load
     # Loads manifest data from public/packs/manifest.json