Add tests for new config types and utils

Author: gauravtiwari

.travis.yml

@@ -24,6 +24,7 @@ install:
   - yarn
 script:
   - yarn lint
+  - yarn test
   - bundle exec rubocop
   - bundle exec rake test
 matrix:

package.json

@@ -42,13 +42,18 @@
     "eslint-config-airbnb": "^14.1.0",
     "eslint-plugin-import": "^2.2.0",
     "eslint-plugin-jsx-a11y": "^4.0.0",
-    "eslint-plugin-react": "^6.10.0"
+    "eslint-plugin-react": "^6.10.0",
+    "jest": "^21.2.1"
+  },
+  "jest": {
+    "testRegex": "(/__tests__/.*|(\\.|/))\\.jsx?$",
+    "roots": ["<rootDir>/package"]
   },
   "peerDependencies": {
     "coffeescript": ">= 1.12.7 || >= 2.x"
   },
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1",
+    "test": "jest",
     "lint": "eslint {package,lib}/"
   },
   "repository": {

package/config_types/__tests__/config_list.js

@@ -0,0 +1,97 @@
+/* global test expect */
+
+const ConfigList = require('../config_list')
+
+test('new', () => {
+  expect(new ConfigList()).toBeInstanceOf(ConfigList)
+})
+
+test('set', () => {
+  const list = new ConfigList()
+  expect(list.set('key', 'value')).toEqual([{ key: 'key', value: 'value' }])
+})
+
+test('get', () => {
+  const list = new ConfigList()
+  list.set('key', 'value')
+  expect(list.get('key')).toEqual('value')
+})
+
+test('append', () => {
+  const list = new ConfigList()
+  list.set('key', 'value')
+  expect(list.append('key1', 'value1')).toEqual([
+    { key: 'key', value: 'value' },
+    { key: 'key1', value: 'value1' }
+  ])
+})
+
+test('prepend', () => {
+  const list = new ConfigList()
+  list.set('key', 'value')
+  expect(list.prepend('key1', 'value1')).toEqual([
+    { key: 'key1', value: 'value1' },
+    { key: 'key', value: 'value' }
+  ])
+})
+
+test('insert without position', () => {
+  const list = new ConfigList()
+  list.set('key', 'value')
+  expect(list.insert('key1', 'value1')).toEqual([
+    { key: 'key', value: 'value' },
+    { key: 'key1', value: 'value1' }
+  ])
+})
+
+test('insert before an item', () => {
+  const list = new ConfigList()
+  list.set('key', 'value')
+  list.set('key1', 'value1')
+  expect(list.insert('key2', 'value2', { before: 'key' })).toEqual([
+    { key: 'key2', value: 'value2' },
+    { key: 'key', value: 'value' },
+    { key: 'key1', value: 'value1' }
+  ])
+})
+
+test('insert after an item', () => {
+  const list = new ConfigList()
+  list.set('key', 'value')
+  list.set('key1', 'value1')
+  expect(list.insert('key2', 'value2', { after: 'key' })).toEqual([
+    { key: 'key', value: 'value' },
+    { key: 'key2', value: 'value2' },
+    { key: 'key1', value: 'value1' }
+  ])
+})
+
+test('delete', () => {
+  const list = new ConfigList()
+  list.set('key', 'value')
+  list.set('key1', 'value1')
+  expect(list.delete('key')).toEqual([{ key: 'key1', value: 'value1' }])
+})
+
+test('getIndex', () => {
+  const list = new ConfigList()
+  list.set('key', 'value')
+  list.set('key1', 'value1')
+  expect(list.getIndex('key')).toEqual(0)
+  expect(list.getIndex('key2')).toEqual(-1)
+  expect(() => list.getIndex('key2', true)).toThrow('Item key2 not found')
+})
+
+test('values', () => {
+  const list = new ConfigList()
+  list.set('key', 'value')
+  list.set('key1', 'value1')
+  expect(list.values()).toEqual(['value', 'value1'])
+})
+
+test('keys', () => {
+  const list = new ConfigList()
+  list.set('key', 'value')
+  list.set('key1', 'value1')
+  expect(list.keys()).toEqual(['key', 'key1'])
+})

package/config_types/__tests__/config_object.js

@@ -0,0 +1,41 @@
+/* global test expect */
+
+const ConfigObject = require('../config_object')
+
+test('new', () => {
+  expect(new ConfigObject()).toBeInstanceOf(ConfigObject)
+})
+
+test('set', () => {
+  const object = new ConfigObject()
+  expect(object.set('key', 'value')).toEqual({ key: 'value' })
+})
+
+test('get', () => {
+  const object = new ConfigObject()
+  object.set('key', 'value')
+  object.set('key1', 'value1')
+  expect(object.get('key')).toEqual('value')
+})
+
+test('delete', () => {
+  const object = new ConfigObject()
+  object.set('key', { key1: 'value' })
+  expect(object.delete('key.key1')).toEqual({ key: {} })
+  expect(object.delete('key')).toEqual({})
+})
+
+test('toObject', () => {
+  const object = new ConfigObject()
+  object.set('key', 'value')
+  object.set('key1', 'value1')
+  expect(object.toObject()).toEqual({ key: 'value', key1: 'value1' })
+})
+
+test('merge', () => {
+  const object = new ConfigObject()
+  object.set('foo', {})
+  expect(object.merge({ key: 'foo', value: 'bar' })).toEqual(
+    { foo: {}, key: 'foo', value: 'bar' }
+  )
+})

package/config_types/config_list.js

@@ -21,12 +21,13 @@ class ConfigList extends Array {
   }
 
   insert(key, value, pos = {}) {
-    const currentIndex = this.getIndex(key)
-    let newIndex = this.getIndex(pos.before || pos.after)
+    if (!(pos.before || pos.after)) return this.append(key, value)
 
+    const currentIndex = this.getIndex(key)
     if (currentIndex >= 0) this.splice(currentIndex, 1)
+
+    let newIndex = this.getIndex(pos.before || pos.after)
     if (pos.after) newIndex += 1
-    if (!(pos.before || pos.after)) newIndex = this.length
 
     this.splice(newIndex, 0, { key, value })
     return this

package/utils/__tests__/deep_assign.js

@@ -0,0 +1,11 @@
+/* global test expect */
+
+const deepAssign = require('../deep_assign')
+
+test('deep assign property', () => {
+  const object = { foo: { bar: { } } }
+  const path = 'foo.bar'
+  const value = { x: 1, y: 2 }
+  const expectation = { foo: { bar: { x: 1, y: 2 } } }
+  expect(deepAssign(object, path, value)).toEqual(expectation)
+})

package/utils/__tests__/deep_merge.js

@@ -0,0 +1,10 @@
+/* global test expect */
+
+const deepMerge = require('../deep_merge')
+
+test('deep merge objects together', () => {
+  const object1 = { foo: { bar: [1, 2, 3], z: 1 }, x: 0 }
+  const object2 = { foo: { bar: ['x', 'y'] }, x: 1, y: 2 }
+  const expectation = { foo: { bar: [1, 2, 3, 'x', 'y'], z: 1 }, x: 1, y: 2 }
+  expect(deepMerge(object1, object2)).toEqual(expectation)
+})

package/utils/__tests__/objectify.js

@@ -0,0 +1,9 @@
+/* global test expect */
+
+const objectify = require('../objectify')
+
+test('Get object from a string path', () => {
+  const object = { foo: { bar: { x: 1 } } }
+  expect(objectify('foo.bar', object)).toEqual({ x: 1 })
+  expect(objectify('some.bar', object)).toEqual(undefined)
+})