From 98c8393a8c24ac19a065cedb6f9a99a78b6dad57 Mon Sep 17 00:00:00 2001 From: Weicheng Zhu Date: Wed, 26 Apr 2017 15:11:27 -0500 Subject: [PATCH 1/7] get rid of babel loader warning `webpack 2.x | babel-loader >= 7.x (recommended) (^6.2.10 will also work, but with deprecation warnings)` https://github.com/babel/babel-loader --- lib/install/template.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/install/template.rb b/lib/install/template.rb index f51347b79..4f36b84f1 100644 --- a/lib/install/template.rb +++ b/lib/install/template.rb @@ -26,7 +26,7 @@ puts "Installing all JavaScript dependencies" run "./bin/yarn add webpack webpack-merge js-yaml path-complete-extname " \ -"webpack-manifest-plugin babel-loader coffee-loader coffee-script " \ +"webpack-manifest-plugin babel-loader@7.x coffee-loader coffee-script " \ "babel-core babel-preset-env compression-webpack-plugin rails-erb-loader glob " \ "extract-text-webpack-plugin node-sass file-loader sass-loader css-loader style-loader " \ "postcss-loader autoprefixer postcss-smart-import precss" From c9106b1dd8c0dafa191243b52b076b60224281c7 Mon Sep 17 00:00:00 2001 From: Weicheng Zhu Date: Mon, 1 May 2017 10:30:05 -0500 Subject: [PATCH 2/7] solve the problem of CORS policy CORS policy: No 'Access-Control-Allow-Origin' --- lib/install/config/webpack/development.server.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/install/config/webpack/development.server.js b/lib/install/config/webpack/development.server.js index fe840c6e4..481ef7c1e 100644 --- a/lib/install/config/webpack/development.server.js +++ b/lib/install/config/webpack/development.server.js @@ -10,6 +10,8 @@ module.exports = merge(devConfig, { host: devServer.host, port: devServer.port, compress: true, + headers: { "Access-Control-Allow-Origin": "*" }, + historyApiFallback: true, contentBase: resolve(paths.output, paths.entry), publicPath From ba6a20634cc2965755cbb6e5d0cfcde571f5588c Mon Sep 17 00:00:00 2001 From: Weicheng Zhu Date: Mon, 1 May 2017 10:30:17 -0500 Subject: [PATCH 3/7] Update development.server.js --- lib/install/config/webpack/development.server.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/install/config/webpack/development.server.js b/lib/install/config/webpack/development.server.js index 481ef7c1e..c49b69bcc 100644 --- a/lib/install/config/webpack/development.server.js +++ b/lib/install/config/webpack/development.server.js @@ -10,8 +10,7 @@ module.exports = merge(devConfig, { host: devServer.host, port: devServer.port, compress: true, - headers: { "Access-Control-Allow-Origin": "*" }, - + headers: { "Access-Control-Allow-Origin": "*" }, historyApiFallback: true, contentBase: resolve(paths.output, paths.entry), publicPath From c645adb0258b8e3c5fcaab375850ccecdb926045 Mon Sep 17 00:00:00 2001 From: davidzhu001 Date: Mon, 1 May 2017 11:55:01 -0500 Subject: [PATCH 4/7] Change the " to ' --- lib/install/config/webpack/development.server.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/install/config/webpack/development.server.js b/lib/install/config/webpack/development.server.js index c49b69bcc..f8c7c12cf 100644 --- a/lib/install/config/webpack/development.server.js +++ b/lib/install/config/webpack/development.server.js @@ -10,7 +10,7 @@ module.exports = merge(devConfig, { host: devServer.host, port: devServer.port, compress: true, - headers: { "Access-Control-Allow-Origin": "*" }, + headers: { 'Access-Control-Allow-Origin': '*' }, historyApiFallback: true, contentBase: resolve(paths.output, paths.entry), publicPath From 8014183114cc504798be8f6b528744d4503df806 Mon Sep 17 00:00:00 2001 From: davidzhu001 Date: Thu, 11 May 2017 14:17:58 -0500 Subject: [PATCH 5/7] Fix production UglifyJS constant error --- lib/install/template.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/install/template.rb b/lib/install/template.rb index 7029531b0..20b8a1003 100644 --- a/lib/install/template.rb +++ b/lib/install/template.rb @@ -30,7 +30,7 @@ puts "Installing all JavaScript dependencies" run "#{RbConfig.ruby} ./bin/yarn add webpack webpack-merge js-yaml path-complete-extname " \ -"webpack-manifest-plugin babel-loader@7.x coffee-loader coffee-script " \ +"webpack-manifest-plugin babel-loader@7.x git://github.com/mishoo/UglifyJS2#harmony coffee-loader coffee-script " \ "babel-core babel-preset-env compression-webpack-plugin rails-erb-loader glob " \ "extract-text-webpack-plugin node-sass file-loader sass-loader css-loader style-loader " \ "postcss-loader autoprefixer postcss-smart-import precss" From 040ead4670498fa3e1f641c022d4e1384f79cabd Mon Sep 17 00:00:00 2001 From: davidzhu001 Date: Fri, 12 May 2017 11:19:13 -0500 Subject: [PATCH 6/7] delele merge branch --- lib/install/template.rb | 5 ----- 1 file changed, 5 deletions(-) diff --git a/lib/install/template.rb b/lib/install/template.rb index a2606a33a..fa600347a 100644 --- a/lib/install/template.rb +++ b/lib/install/template.rb @@ -23,13 +23,8 @@ end puts "Installing all JavaScript dependencies" -<<<<<<< HEAD -run "#{RbConfig.ruby} ./bin/yarn add webpack webpack-merge js-yaml path-complete-extname " \ -"webpack-manifest-plugin babel-loader@7.x git://github.com/mishoo/UglifyJS2#harmony coffee-loader coffee-script " \ -======= run "yarn add webpack webpack-merge js-yaml path-complete-extname " \ "webpack-manifest-plugin babel-loader@7.x coffee-loader coffee-script " \ ->>>>>>> rails/master "babel-core babel-preset-env compression-webpack-plugin rails-erb-loader glob " \ "extract-text-webpack-plugin node-sass file-loader sass-loader css-loader style-loader " \ "postcss-loader autoprefixer postcss-smart-import precss" From 3d8d4cd56207cf61cb0e3c6da9c8c4fe90deedb5 Mon Sep 17 00:00:00 2001 From: davidzhu001 Date: Fri, 12 May 2017 11:38:49 -0500 Subject: [PATCH 7/7] UglifyJS Readme --- README.md | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/README.md b/README.md index 9ed33ee39..71acb6ad4 100644 --- a/README.md +++ b/README.md @@ -238,6 +238,29 @@ Therefore, make sure webpack (i.e `./bin/webpack-dev-server`) is running and has completed the compilation successfully before loading a view. +### UglifyJS issue +* if you run to the problems with Uglify see issue [#381](https://github.com/rails/webpacker/issues/306#issuecomment-299493349)[#291](https://github.com/rails/webpacker/pull/291) + 1. `Unexpected token punc «(», expected punc «:» ` + 2. `Unexpected token: punc ()) ` +* Solution one: +``` +#./.babelrc +{ + "presets": [ + ["env", { + "modules": false, + "targets": { + "uglify": true + } + ] +} +``` +* Solution two: +``` +# in package.json: +"uglify-js": "git://github.com/mishoo/UglifyJS2#harmony" +``` + ## Wishlist - Improve process for linking to assets compiled by sprockets - shouldn't need to specify