Skip to content

Commit 0abd337

Browse files
Phil Elwellpopcornmix
Phil Elwell
authored andcommitted
gpiolib: Don't prevent IRQ usage of output GPIOs
Upstream Linux deems using output GPIOs to generate IRQs as a bogus use case, even though the BCM2835 GPIO controller is capable of doing so. A number of users would like to make use of this facility, so disable the checks. See: #2527 Signed-off-by: Phil Elwell <[email protected]>
1 parent 6ab6243 commit 0abd337

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

drivers/gpio/gpiolib.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@
5151
* GPIOs can sometimes cost only an instruction or two per bit.
5252
*/
5353

54+
#define dont_test_bit(b,d) (0)
55+
5456
/* Device and char device-related information */
5557
static DEFINE_IDA(gpio_ida);
5658
static dev_t gpio_devt;
@@ -2814,8 +2816,8 @@ int gpiod_direction_output(struct gpio_desc *desc, int value)
28142816
value = !!value;
28152817

28162818
/* GPIOs used for enabled IRQs shall not be set as output */
2817-
if (test_bit(FLAG_USED_AS_IRQ, &flags) &&
2818-
test_bit(FLAG_IRQ_IS_ENABLED, &flags)) {
2819+
if (dont_test_bit(FLAG_USED_AS_IRQ, &flags) &&
2820+
dont_test_bit(FLAG_IRQ_IS_ENABLED, &flags)) {
28192821
gpiod_err(desc,
28202822
"%s: tried to set a GPIO tied to an IRQ as output\n",
28212823
__func__);
@@ -3766,8 +3768,8 @@ int gpiochip_lock_as_irq(struct gpio_chip *gc, unsigned int offset)
37663768
}
37673769

37683770
/* To be valid for IRQ the line needs to be input or open drain */
3769-
if (test_bit(FLAG_IS_OUT, &desc->flags) &&
3770-
!test_bit(FLAG_OPEN_DRAIN, &desc->flags)) {
3771+
if (dont_test_bit(FLAG_IS_OUT, &desc->flags) &&
3772+
!dont_test_bit(FLAG_OPEN_DRAIN, &desc->flags)) {
37713773
chip_err(gc,
37723774
"%s: tried to flag a GPIO set as output for IRQ\n",
37733775
__func__);

0 commit comments

Comments
 (0)