Skip to content

Commit 10ff697

Browse files
JamesH65popcornmix
authored andcommitted
drm/vc4: Fix for margins in composite/SDTV mode (#3223)
Margins were incorrectly assumed to be setup in SDTV mode, but were not actually done, so this make the setup non-conditional on mode. Signed-off-by: James Hughes <[email protected]>
1 parent 50d5e8f commit 10ff697

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

drivers/gpu/drm/vc4/vc4_firmware_kms.c

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1610,14 +1610,9 @@ vc4_fkms_connector_init(struct drm_device *dev, struct drm_encoder *encoder,
16101610
connector->interlace_allowed = 0;
16111611
}
16121612

1613-
/* Create and attach TV margin props to this connector.
1614-
* Already done for SDTV outputs.
1615-
*/
1616-
if (fkms_connector->display_type != DRM_MODE_ENCODER_TVDAC) {
1617-
ret = drm_mode_create_tv_margin_properties(dev);
1618-
if (ret)
1619-
goto fail;
1620-
}
1613+
ret = drm_mode_create_tv_margin_properties(dev);
1614+
if (ret)
1615+
goto fail;
16211616

16221617
drm_connector_attach_tv_margin_properties(connector);
16231618

0 commit comments

Comments
 (0)