Skip to content

Commit 28c5bcf

Browse files
Scott Woodmpe
Scott Wood
authored andcommitted
KVM: PPC: Move and undef TRACE_INCLUDE_PATH/FILE
TRACE_INCLUDE_PATH and TRACE_INCLUDE_FILE are used by <trace/define_trace.h>, so like that #include, they should be outside #ifdef protection. They also need to be #undefed before defining, in case multiple trace headers are included by the same C file. This became the case on book3e after commit cf4a608 ("powerpc/mm: Add missing tracepoint for tlbie"), leading to the following build error: CC arch/powerpc/kvm/powerpc.o In file included from arch/powerpc/kvm/powerpc.c:51:0: arch/powerpc/kvm/trace.h:9:0: error: "TRACE_INCLUDE_PATH" redefined [-Werror] #define TRACE_INCLUDE_PATH . ^ In file included from arch/powerpc/kvm/../mm/mmu_decl.h:25:0, from arch/powerpc/kvm/powerpc.c:48: ./arch/powerpc/include/asm/trace.h:224:0: note: this is the location of the previous definition #define TRACE_INCLUDE_PATH asm ^ cc1: all warnings being treated as errors Reported-by: Christian Zigotzky <[email protected]> Signed-off-by: Scott Wood <[email protected]> Signed-off-by: Michael Ellerman <[email protected]>
1 parent 9586d56 commit 28c5bcf

File tree

4 files changed

+27
-8
lines changed

4 files changed

+27
-8
lines changed

arch/powerpc/kvm/trace.h

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66

77
#undef TRACE_SYSTEM
88
#define TRACE_SYSTEM kvm
9-
#define TRACE_INCLUDE_PATH .
10-
#define TRACE_INCLUDE_FILE trace
119

1210
/*
1311
* Tracepoint for guest mode entry.
@@ -120,4 +118,10 @@ TRACE_EVENT(kvm_check_requests,
120118
#endif /* _TRACE_KVM_H */
121119

122120
/* This part must be outside protection */
121+
#undef TRACE_INCLUDE_PATH
122+
#undef TRACE_INCLUDE_FILE
123+
124+
#define TRACE_INCLUDE_PATH .
125+
#define TRACE_INCLUDE_FILE trace
126+
123127
#include <trace/define_trace.h>

arch/powerpc/kvm/trace_booke.h

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66

77
#undef TRACE_SYSTEM
88
#define TRACE_SYSTEM kvm_booke
9-
#define TRACE_INCLUDE_PATH .
10-
#define TRACE_INCLUDE_FILE trace_booke
119

1210
#define kvm_trace_symbol_exit \
1311
{0, "CRITICAL"}, \
@@ -218,4 +216,11 @@ TRACE_EVENT(kvm_booke_queue_irqprio,
218216
#endif
219217

220218
/* This part must be outside protection */
219+
220+
#undef TRACE_INCLUDE_PATH
221+
#undef TRACE_INCLUDE_FILE
222+
223+
#define TRACE_INCLUDE_PATH .
224+
#define TRACE_INCLUDE_FILE trace_booke
225+
221226
#include <trace/define_trace.h>

arch/powerpc/kvm/trace_hv.h

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99

1010
#undef TRACE_SYSTEM
1111
#define TRACE_SYSTEM kvm_hv
12-
#define TRACE_INCLUDE_PATH .
13-
#define TRACE_INCLUDE_FILE trace_hv
1412

1513
#define kvm_trace_symbol_hcall \
1614
{H_REMOVE, "H_REMOVE"}, \
@@ -497,4 +495,11 @@ TRACE_EVENT(kvmppc_run_vcpu_exit,
497495
#endif /* _TRACE_KVM_HV_H */
498496

499497
/* This part must be outside protection */
498+
499+
#undef TRACE_INCLUDE_PATH
500+
#undef TRACE_INCLUDE_FILE
501+
502+
#define TRACE_INCLUDE_PATH .
503+
#define TRACE_INCLUDE_FILE trace_hv
504+
500505
#include <trace/define_trace.h>

arch/powerpc/kvm/trace_pr.h

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88

99
#undef TRACE_SYSTEM
1010
#define TRACE_SYSTEM kvm_pr
11-
#define TRACE_INCLUDE_PATH .
12-
#define TRACE_INCLUDE_FILE trace_pr
1311

1412
TRACE_EVENT(kvm_book3s_reenter,
1513
TP_PROTO(int r, struct kvm_vcpu *vcpu),
@@ -257,4 +255,11 @@ TRACE_EVENT(kvm_exit,
257255
#endif /* _TRACE_KVM_H */
258256

259257
/* This part must be outside protection */
258+
259+
#undef TRACE_INCLUDE_PATH
260+
#undef TRACE_INCLUDE_FILE
261+
262+
#define TRACE_INCLUDE_PATH .
263+
#define TRACE_INCLUDE_FILE trace_pr
264+
260265
#include <trace/define_trace.h>

0 commit comments

Comments
 (0)