Skip to content

Commit 2c6c9c0

Browse files
FlyGoatMarc Zyngier
authored and
Marc Zyngier
committed
irqchip/mips-gic: Don't touch vl_map if a local interrupt is not routable
When a GIC local interrupt is not routable, it's vl_map will be used to control some internal states for core (providing IPTI, IPPCI, IPFDC input signal for core). Overriding it will interfere core's intetrupt controller. Do not touch vl_map if a local interrupt is not routable, we are not going to remap it. Before dd098a0 (" irqchip/mips-gic: Get rid of the reliance on irq_cpu_online()"), if a local interrupt is not routable, then it won't be requested from GIC Local domain, and thus gic_all_vpes_irq_cpu_online won't be called for that particular interrupt. Fixes: dd098a0 (" irqchip/mips-gic: Get rid of the reliance on irq_cpu_online()") Cc: [email protected] Signed-off-by: Jiaxun Yang <[email protected]> Reviewed-by: Serge Semin <[email protected]> Tested-by: Serge Semin <[email protected]> Signed-off-by: Marc Zyngier <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 44bd78d commit 2c6c9c0

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/irqchip/irq-mips-gic.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -399,6 +399,8 @@ static void gic_all_vpes_irq_cpu_online(void)
399399
unsigned int intr = local_intrs[i];
400400
struct gic_all_vpes_chip_data *cd;
401401

402+
if (!gic_local_irq_is_routable(intr))
403+
continue;
402404
cd = &gic_all_vpes_chip_data[intr];
403405
write_gic_vl_map(mips_gic_vx_map_reg(intr), cd->map);
404406
if (cd->mask)

0 commit comments

Comments
 (0)