Skip to content

Commit 2f230c9

Browse files
Phil Elwellpopcornmix
Phil Elwell
authored andcommitted
gpiolib: Don't prevent IRQ usage of output GPIOs
Upstream Linux deems using output GPIOs to generate IRQs as a bogus use case, even though the BCM2835 GPIO controller is capable of doing so. A number of users would like to make use of this facility, so disable the checks. See: #2527 Signed-off-by: Phil Elwell <[email protected]>
1 parent 7be43f6 commit 2f230c9

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

drivers/gpio/gpiolib.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@
5050
* GPIOs can sometimes cost only an instruction or two per bit.
5151
*/
5252

53+
#define dont_test_bit(b,d) (0)
54+
5355
/* Device and char device-related information */
5456
static DEFINE_IDA(gpio_ida);
5557
static dev_t gpio_devt;
@@ -2859,8 +2861,8 @@ int gpiod_direction_output_nonotify(struct gpio_desc *desc, int value)
28592861
value = !!value;
28602862

28612863
/* GPIOs used for enabled IRQs shall not be set as output */
2862-
if (test_bit(FLAG_USED_AS_IRQ, &flags) &&
2863-
test_bit(FLAG_IRQ_IS_ENABLED, &flags)) {
2864+
if (dont_test_bit(FLAG_USED_AS_IRQ, &flags) &&
2865+
dont_test_bit(FLAG_IRQ_IS_ENABLED, &flags)) {
28642866
gpiod_err(desc,
28652867
"%s: tried to set a GPIO tied to an IRQ as output\n",
28662868
__func__);
@@ -3834,8 +3836,8 @@ int gpiochip_lock_as_irq(struct gpio_chip *gc, unsigned int offset)
38343836
}
38353837

38363838
/* To be valid for IRQ the line needs to be input or open drain */
3837-
if (test_bit(FLAG_IS_OUT, &desc->flags) &&
3838-
!test_bit(FLAG_OPEN_DRAIN, &desc->flags)) {
3839+
if (dont_test_bit(FLAG_IS_OUT, &desc->flags) &&
3840+
!dont_test_bit(FLAG_OPEN_DRAIN, &desc->flags)) {
38393841
chip_err(gc,
38403842
"%s: tried to flag a GPIO set as output for IRQ\n",
38413843
__func__);

0 commit comments

Comments
 (0)