Skip to content

Commit 53934dd

Browse files
ideakgregkh
authored andcommitted
drm/i915: Enable display WA#1183 from its correct spot
commit ac315c6 upstream. The DMC FW specific part of display WA#1183 is supposed to be enabled whenever enabling DC5 or DC6, so move it to the DC6 enable function from the DC6 disable function. I noticed this after Daniel's patch to remove the unused skl_disable_dc6() function. Fixes: 53421c2 ("drm/i915: Apply Display WA #1183 on skl, kbl, and cfl") Cc: Lucas De Marchi <[email protected]> Cc: Rodrigo Vivi <[email protected]> Cc: Ville Syrjälä <[email protected]> Cc: Daniel Vetter <[email protected]> Cc: <[email protected]> Signed-off-by: Imre Deak <[email protected]> Reviewed-by: Ville Syrjälä <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] (cherry picked from commit b49be66) Signed-off-by: Joonas Lahtinen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 3dbfc2b commit 53934dd

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

drivers/gpu/drm/i915/intel_runtime_pm.c

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -624,19 +624,18 @@ void skl_enable_dc6(struct drm_i915_private *dev_priv)
624624

625625
DRM_DEBUG_KMS("Enabling DC6\n");
626626

627-
gen9_set_dc_state(dev_priv, DC_STATE_EN_UPTO_DC6);
627+
/* Wa Display #1183: skl,kbl,cfl */
628+
if (IS_GEN9_BC(dev_priv))
629+
I915_WRITE(GEN8_CHICKEN_DCPR_1, I915_READ(GEN8_CHICKEN_DCPR_1) |
630+
SKL_SELECT_ALTERNATE_DC_EXIT);
628631

632+
gen9_set_dc_state(dev_priv, DC_STATE_EN_UPTO_DC6);
629633
}
630634

631635
void skl_disable_dc6(struct drm_i915_private *dev_priv)
632636
{
633637
DRM_DEBUG_KMS("Disabling DC6\n");
634638

635-
/* Wa Display #1183: skl,kbl,cfl */
636-
if (IS_GEN9_BC(dev_priv))
637-
I915_WRITE(GEN8_CHICKEN_DCPR_1, I915_READ(GEN8_CHICKEN_DCPR_1) |
638-
SKL_SELECT_ALTERNATE_DC_EXIT);
639-
640639
gen9_set_dc_state(dev_priv, DC_STATE_DISABLE);
641640
}
642641

0 commit comments

Comments
 (0)