overlays: pisound: Make button pins owned by card

The pisound overlay claims a number of GPIOs using a pinctrl node, but
for some reason hangs this claim on the main gpio node. This obscures
the ownership of the pins (as shown by gpioinfo and in the kernel logs)
and isn't scalable - only one overlay can use the trick at a time.

Change the overlay to make the pin ownership clear and avoid any future
conflicts, removing a bogus claim on pins_spi0 at the same time.

See: #5235

Signed-off-by: Phil Elwell <[email protected]>

Author: pelwell

arch/arm/boot/dts/overlays/pisound-overlay.dts

@@ -55,8 +55,6 @@
 			pisound_spi: pisound_spi@0{
 				compatible = "blokaslabs,pisound-spi";
 				reg = <0>;
-				pinctrl-names = "default";
-				pinctrl-0 = <&spi0_pins>;
 				spi-max-frequency = <1000000>;
 			};
 		};
@@ -80,6 +78,7 @@
 			i2s-controller = <&i2s>;
 			status = "okay";
 
+			pinctrl-names = "default";
 			pinctrl-0 = <&pisound_button_pins>;
 
 			osr-gpios =
@@ -100,9 +99,6 @@
 	fragment@6 {
 		target = <&gpio>;
 		__overlay__ {
-			pinctrl-names = "default";
-			pinctrl-0 = <&pisound_button_pins>;
-
 			pisound_button_pins: pisound_button_pins {
 				brcm,pins = <17>;
 				brcm,function = <0>; // Input