Skip to content

Commit 5769500

Browse files
peat-psuwitpelwell
authored andcommitted
drm/rp1: depends on, instead of select, MFD_RP1
According to kconfig-language.txt [1], select should be used only for "non-visible symbols ... and for symbols with no dependencies". Since MFD_RP1 both is visible and has a dependency, "select" should not be used and "depends on" should be used instead. In particular, this fixes the build of this kernel tree on NixOS, where its kernel config system will try to answer 'M' to as many config as possible. [1] https://www.kernel.org/doc/html/latest/kbuild/kconfig-language.html Signed-off-by: Ratchanan Srirattanamet <[email protected]>
1 parent 86450c7 commit 5769500

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

drivers/gpu/drm/rp1/rp1-dpi/Kconfig

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
# SPDX-License-Identifier: GPL-2.0-only
22
config DRM_RP1_DPI
33
tristate "DRM Support for RP1 DPI"
4-
depends on DRM
5-
select MFD_RP1
4+
depends on DRM && MFD_RP1
65
select DRM_GEM_DMA_HELPER
76
select DRM_KMS_HELPER
87
select DRM_VRAM_HELPER

drivers/gpu/drm/rp1/rp1-dsi/Kconfig

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
# SPDX-License-Identifier: GPL-2.0-only
22
config DRM_RP1_DSI
33
tristate "DRM Support for RP1 DSI"
4-
depends on DRM
5-
select MFD_RP1
4+
depends on DRM && MFD_RP1
65
select DRM_GEM_DMA_HELPER
76
select DRM_KMS_HELPER
87
select DRM_MIPI_DSI

drivers/gpu/drm/rp1/rp1-vec/Kconfig

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
# SPDX-License-Identifier: GPL-2.0-only
22
config DRM_RP1_VEC
33
tristate "DRM Support for RP1 VEC"
4-
depends on DRM
5-
select MFD_RP1
4+
depends on DRM && MFD_RP1
65
select DRM_GEM_DMA_HELPER
76
select DRM_KMS_HELPER
87
select DRM_VRAM_HELPER

0 commit comments

Comments
 (0)