overlays: Add 'combine' option to i2c overlays

The i2c0-bcm2708 and i2c1-bcm2708 overlays allow the I2C pin usage to
be changed. The names also suggest they revert to the old i2c_bcm2708
driver, but they don't. The newer i2c_bcm2835 driver forces
transactions to be combined where possible, but this breaks some
devices.

Add an option to disable transaction combining, which is currently
implemented by reverting to the old driver.

See: raspberrypi/firmware#828

Signed-off-by: Phil Elwell <[email protected]>

Author: Phil Elwell

arch/arm/boot/dts/overlays/README

@@ -865,24 +865,32 @@ Params: addr                    Set the address for the BME280, BMP280, DS1621,
 
 
 Name:   i2c0-bcm2708
-Info:   Enable the i2c_bcm2708 driver for the i2c0 bus. Not all pin combinations
-        are usable on all platforms.
+Info:   Change i2c0 pin usage. Not all pin combinations are usable on all
+        platforms - platforms other then Compute Modules can only use this
+        to disable transaction combining.
 Load:   dtoverlay=i2c0-bcm2708,<param>=<val>
 Params: sda0_pin                GPIO pin for SDA0 (deprecated - use pins_*)
         scl0_pin                GPIO pin for SCL0 (deprecated - use pins_*)
         pins_0_1                Use pins 0 and 1 (default)
         pins_28_29              Use pins 28 and 29
         pins_44_45              Use pins 44 and 45
         pins_46_47              Use pins 46 and 47
+        combine                 Allow transactions to be combined (default
+                                "yes")
 
 
 Name:   i2c1-bcm2708
+Info:   Change i2c1 pin usage. Not all pin combinations are usable on all
+        platforms - platforms other then Compute Modules can only use this
+        to disable transaction combining.
 Info:   Enable the i2c_bcm2708 driver for the i2c1 bus
 Load:   dtoverlay=i2c1-bcm2708,<param>=<val>
 Params: sda1_pin                GPIO pin for SDA1 (2 or 44 - default 2)
         scl1_pin                GPIO pin for SCL1 (3 or 45 - default 3)
         pin_func                Alternative pin function (4 (alt0), 6 (alt2) -
                                 default 4)
+        combine                 Allow transactions to be combined (default
+                                "yes")
 
 
 Name:   i2s-gpio28-31

arch/arm/boot/dts/overlays/i2c0-bcm2708-overlay.dts

@@ -50,12 +50,20 @@
       };
    };
 
+   fragment@5 {
+      target = <&i2c0>;
+      __dormant__ {
+         compatible = "brcm,bcm2708-i2c";
+      };
+   };
+
    __overrides__ {
       sda0_pin = <&frag1>,"brcm,pins:0";
       scl0_pin = <&frag1>,"brcm,pins:4";
       pins_0_1   = <0>,"+1-2-3-4";
       pins_28_29 = <0>,"-1+2-3-4";
       pins_44_45 = <0>,"-1-2+3-4";
       pins_46_47 = <0>,"-1-2-3+4";
+      combine = <0>, "!5";
    };
 };

arch/arm/boot/dts/overlays/i2c1-bcm2708-overlay.dts

@@ -26,9 +26,18 @@
          brcm,function = <4>; /* alt 0 */
       };
    };
+
+   fragment@2 {
+      target = <&i2c1>;
+      __dormant__ {
+         compatible = "brcm,bcm2708-i2c";
+      };
+   };
+
    __overrides__ {
       sda1_pin = <&pins>,"brcm,pins:0";
       scl1_pin = <&pins>,"brcm,pins:4";
       pin_func = <&pins>,"brcm,function:0";
+      combine = <0>, "!2";
    };
 };