Skip to content

Commit 6cbe21f

Browse files
davidplowmanpelwell
authored andcommitted
drivers/gpu/drm/vc4: Add missing 32-bit RGB formats
The missing 32-bit per pixel ABGR and various "RGB with an X value" formats are added. Change sent by Dave Stevenson. Signed-off-by: David Plowman <[email protected]>
1 parent 26721d7 commit 6cbe21f

File tree

1 file changed

+16
-12
lines changed

1 file changed

+16
-12
lines changed

drivers/gpu/drm/vc4/vc4_firmware_kms.c

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -184,18 +184,22 @@ static const struct vc_image_format {
184184
.drm = DRM_FORMAT_ARGB8888,
185185
.vc_image = VC_IMAGE_ARGB8888,
186186
},
187-
/*
188-
* FIXME: Need to resolve which DRM format goes to which vc_image format
189-
* for the remaining RGBA and RGBX formats.
190-
* {
191-
* .drm = DRM_FORMAT_ABGR8888,
192-
* .vc_image = VC_IMAGE_RGBA8888,
193-
* },
194-
* {
195-
* .drm = DRM_FORMAT_XBGR8888,
196-
* .vc_image = VC_IMAGE_RGBA8888,
197-
* },
198-
*/
187+
{
188+
.drm = DRM_FORMAT_XBGR8888,
189+
.vc_image = VC_IMAGE_RGBX32,
190+
},
191+
{
192+
.drm = DRM_FORMAT_ABGR8888,
193+
.vc_image = VC_IMAGE_RGBA32,
194+
},
195+
{
196+
.drm = DRM_FORMAT_RGBX8888,
197+
.vc_image = VC_IMAGE_BGRX8888,
198+
},
199+
{
200+
.drm = DRM_FORMAT_BGRX8888,
201+
.vc_image = VC_IMAGE_RGBX8888,
202+
},
199203
{
200204
.drm = DRM_FORMAT_RGB565,
201205
.vc_image = VC_IMAGE_RGB565,

0 commit comments

Comments
 (0)