drm/panel: Add and initialise an orientation field to drm_panel

Current usage of drm_connector_set_panel_orientation is from a panel's
get_modes call. However if the panel orientation property doesn't
exist on the connector at this point, then drm_mode_object triggers
WARNs as the connector is already registered.

Add an orientation variable to struct drm_panel and initialise it from
drm_panel_init.
panel_bridge_attach can then create the property before the connector
is registered.

Signed-off-by: Dave Stevenson <[email protected]>

Author: 6by9

drivers/gpu/drm/bridge/panel.c

@@ -79,6 +79,10 @@ static int panel_bridge_attach(struct drm_bridge *bridge,
 		return ret;
 	}
 
+	/* set up connector's "panel orientation" property */
+	drm_connector_set_panel_orientation(&panel_bridge->connector,
+					    panel_bridge->panel->orientation);
+
 	drm_connector_attach_encoder(&panel_bridge->connector,
 					  bridge->encoder);
 

drivers/gpu/drm/drm_panel.c

@@ -61,6 +61,21 @@ void drm_panel_init(struct drm_panel *panel, struct device *dev,
 	panel->dev = dev;
 	panel->funcs = funcs;
 	panel->connector_type = connector_type;
+#ifdef CONFIG_OF
+	{
+		int ret;
+
+		ret = of_drm_get_panel_orientation(dev->of_node,
+						   &panel->orientation);
+		if (ret) {
+			DRM_DEV_ERROR(panel->dev, "%pOF: failed to get orientation %d\n",
+				      dev->of_node, ret);
+			panel->orientation = DRM_MODE_PANEL_ORIENTATION_UNKNOWN;
+		}
+	}
+#else
+	panel->orientation = DRM_MODE_PANEL_ORIENTATION_UNKNOWN;
+#endif
 }
 EXPORT_SYMBOL(drm_panel_init);
 

include/drm/drm_panel.h

@@ -165,6 +165,14 @@ struct drm_panel {
 	 */
 	int connector_type;
 
+	/**
+	 * @orientation:
+	 *
+	 * Panel orientation at initialisation. This is used to initialise the
+	 * drm_connector property for panel orientation.
+	 */
+	enum drm_panel_orientation orientation;
+
 	/**
 	 * @list:
 	 *