Skip to content

Commit 8ddd03a

Browse files
committed
drm/vc4: Correct DSI register definition
The DSI1_PHY_AFEC0_PD_DLANE1 and DSI1_PHY_AFEC0_PD_DLANE3 register definitions were swapped, so trying to use more than a single data lane failed as lane 1 would get powered down. (In theory a 4 lane device would work as all lanes would remain powered). Correct the definitions. Signed-off-by: Dave Stevenson <[email protected]>
1 parent 42aa6ae commit 8ddd03a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/vc4/vc4_dsi.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -306,11 +306,11 @@
306306
# define DSI0_PHY_AFEC0_RESET BIT(11)
307307
# define DSI1_PHY_AFEC0_PD_BG BIT(11)
308308
# define DSI0_PHY_AFEC0_PD BIT(10)
309-
# define DSI1_PHY_AFEC0_PD_DLANE3 BIT(10)
309+
# define DSI1_PHY_AFEC0_PD_DLANE3 BIT(8)
310310
# define DSI0_PHY_AFEC0_PD_BG BIT(9)
311311
# define DSI1_PHY_AFEC0_PD_DLANE2 BIT(9)
312312
# define DSI0_PHY_AFEC0_PD_DLANE1 BIT(8)
313-
# define DSI1_PHY_AFEC0_PD_DLANE1 BIT(8)
313+
# define DSI1_PHY_AFEC0_PD_DLANE1 BIT(10)
314314
# define DSI_PHY_AFEC0_PTATADJ_MASK VC4_MASK(7, 4)
315315
# define DSI_PHY_AFEC0_PTATADJ_SHIFT 4
316316
# define DSI_PHY_AFEC0_CTATADJ_MASK VC4_MASK(3, 0)

0 commit comments

Comments
 (0)