Skip to content

Commit 9962572

Browse files
committed
staging: bcm2835_codec: Clean up logging on unloading the driver
The log line was missing a closing \n, so wasn't added to the log immediately. Adds the function of the V4L2 device that is being unregistered too. Signed-off-by: Dave Stevenson <[email protected]>
1 parent 6dc4395 commit 9962572

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

drivers/staging/vc04_services/bcm2835-codec/bcm2835-v4l2-codec.c

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,12 @@ enum bcm2835_codec_role {
7777
ISP,
7878
};
7979

80+
const static char *roles[] = {
81+
"decode",
82+
"encode",
83+
"isp"
84+
};
85+
8086
static const char * const components[] = {
8187
"ril.video_decode",
8288
"ril.video_encode",
@@ -2511,7 +2517,6 @@ static int bcm2835_codec_create(struct platform_device *pdev,
25112517
struct video_device *vfd;
25122518
int video_nr;
25132519
int ret;
2514-
const static char *roles[] = {"decode", "encode", "isp"};
25152520

25162521
dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
25172522
if (!dev)
@@ -2604,7 +2609,8 @@ static int bcm2835_codec_destroy(struct bcm2835_codec_dev *dev)
26042609
if (!dev)
26052610
return -ENODEV;
26062611

2607-
v4l2_info(&dev->v4l2_dev, "Removing " MEM2MEM_NAME);
2612+
v4l2_info(&dev->v4l2_dev, "Removing " MEM2MEM_NAME ", %s\n",
2613+
roles[dev->role]);
26082614
v4l2_m2m_release(dev->m2m_dev);
26092615
video_unregister_device(&dev->vfd);
26102616
v4l2_device_unregister(&dev->v4l2_dev);

0 commit comments

Comments
 (0)