Skip to content

Commit c1afb26

Browse files
Po-Hao HuangKalle Valo
Po-Hao Huang
authored and
Kalle Valo
committed
rtw88: 8822c: update rx settings to prevent potential hw deadlock
These settings enables mac to detect and recover when rx fifo circuit deadlock occurs. Previous version missed this, so we fix it. Signed-off-by: Po-Hao Huang <[email protected]> Signed-off-by: Ping-Ke Shih <[email protected]> Signed-off-by: Kalle Valo <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent a3fd1f9 commit c1afb26

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

drivers/net/wireless/realtek/rtw88/main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1869,7 +1869,7 @@ int rtw_core_init(struct rtw_dev *rtwdev)
18691869

18701870
/* default rx filter setting */
18711871
rtwdev->hal.rcr = BIT_APP_FCS | BIT_APP_MIC | BIT_APP_ICV |
1872-
BIT_HTC_LOC_CTRL | BIT_APP_PHYSTS |
1872+
BIT_PKTCTL_DLEN | BIT_HTC_LOC_CTRL | BIT_APP_PHYSTS |
18731873
BIT_AB | BIT_AM | BIT_APM;
18741874

18751875
ret = rtw_load_firmware(rtwdev, RTW_NORMAL_FW);

drivers/net/wireless/realtek/rtw88/rtw8821c.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ _rtw_write32s_mask(struct rtw_dev *rtwdev, u32 addr, u32 mask, u32 data)
131131
#define WLAN_TX_FUNC_CFG2 0x30
132132
#define WLAN_MAC_OPT_NORM_FUNC1 0x98
133133
#define WLAN_MAC_OPT_LB_FUNC1 0x80
134-
#define WLAN_MAC_OPT_FUNC2 0x30810041
134+
#define WLAN_MAC_OPT_FUNC2 0xb0810041
135135

136136
#define WLAN_SIFS_CFG (WLAN_SIFS_CCK_CONT_TX | \
137137
(WLAN_SIFS_OFDM_CONT_TX << BIT_SHIFT_SIFS_OFDM_CTX) | \

drivers/net/wireless/realtek/rtw88/rtw8822b.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ static void rtw8822b_phy_set_param(struct rtw_dev *rtwdev)
205205
#define WLAN_TX_FUNC_CFG2 0x30
206206
#define WLAN_MAC_OPT_NORM_FUNC1 0x98
207207
#define WLAN_MAC_OPT_LB_FUNC1 0x80
208-
#define WLAN_MAC_OPT_FUNC2 0x30810041
208+
#define WLAN_MAC_OPT_FUNC2 0xb0810041
209209

210210
#define WLAN_SIFS_CFG (WLAN_SIFS_CCK_CONT_TX | \
211211
(WLAN_SIFS_OFDM_CONT_TX << BIT_SHIFT_SIFS_OFDM_CTX) | \

drivers/net/wireless/realtek/rtw88/rtw8822c.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1962,7 +1962,7 @@ static void rtw8822c_phy_set_param(struct rtw_dev *rtwdev)
19621962
#define WLAN_TX_FUNC_CFG2 0x30
19631963
#define WLAN_MAC_OPT_NORM_FUNC1 0x98
19641964
#define WLAN_MAC_OPT_LB_FUNC1 0x80
1965-
#define WLAN_MAC_OPT_FUNC2 0x30810041
1965+
#define WLAN_MAC_OPT_FUNC2 0xb0810041
19661966
#define WLAN_MAC_INT_MIG_CFG 0x33330000
19671967

19681968
#define WLAN_SIFS_CFG (WLAN_SIFS_CCK_CONT_TX | \

0 commit comments

Comments
 (0)