e1000: remove unneeded conversion to bool

JasonYanHw · davem330 · commit c95576a34cf7 · 2020-04-21T15:45:32.000-07:00
The '==' expression itself is bool, no need to convert it to bool again.
This fixes the following coccicheck warning:

drivers/net/ethernet/intel/e1000/e1000_main.c:1479:44-49: WARNING:
conversion to bool not needed here

Signed-off-by: Jason Yan &lt;yanaijie@huawei.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
@@ -1476,7 +1476,7 @@ static bool e1000_check_64k_bound(struct e1000_adapter *adapter, void *start,
 	if (hw->mac_type == e1000_82545 ||
 	    hw->mac_type == e1000_ce4100 ||
 	    hw->mac_type == e1000_82546) {
-		return ((begin ^ (end - 1)) >> 16) != 0 ? false : true;
+		return ((begin ^ (end - 1)) >> 16) == 0;
 	}
 
 	return true;

Original file line number	Diff line number	Diff line change
`@@ -1476,7 +1476,7 @@ static bool e1000_check_64k_bound(struct e1000_adapter adapter, void start,`
`1476`	`1476`	`if (hw->mac_type == e1000_82545 \|\|`
`1477`	`1477`	`hw->mac_type == e1000_ce4100 \|\|`
`1478`	`1478`	`hw->mac_type == e1000_82546) {`
`1479`		`- return ((begin ^ (end - 1)) >> 16) != 0 ? false : true;`
	`1479`	`+ return ((begin ^ (end - 1)) >> 16) == 0;`
`1480`	`1480`	`}`
`1481`	`1481`
`1482`	`1482`	`return true;`