Skip to content

Commit cef5356

Browse files
committed
bcm2835-unicam: Increase the size of the dummy buffer
Increase the size of the dummy buffer to store a single line of 64 Mpix resolution at 10bpp. This is a speculative change to avoid possible hardware overruns when running in a circular buffer modes. It is unclear if the hardware checks for overruns on every AXI write, or on line boundaries. Signed-off-by: Naushir Patuck <[email protected]>
1 parent 9d0922a commit cef5356

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/media/platform/bcm2835/bcm2835-unicam.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,15 +127,15 @@ MODULE_PARM_DESC(media_controller, "Use media controller API");
127127
#define UNICAM_EMBEDDED_SIZE 16384
128128

129129
/*
130-
* Size of the dummy buffer. Can be any size really, but the DMA
131-
* allocation works in units of page sizes.
130+
* Size of the dummy buffer. This is currently sized to fill a single line of
131+
* 64 Mpix resolution at 10bpp.
132132
*
133133
* Due to a HW bug causing buffer overruns in circular buffer mode under certain
134134
* (not yet fully known) conditions, the dummy buffer allocation is twice as big
135135
* as needed, and the buffer end address register is calculated with a size of
136136
* DUMMY_BUF_SIZE.
137137
*/
138-
#define DUMMY_BUF_SIZE (PAGE_SIZE)
138+
#define DUMMY_BUF_SIZE (PAGE_SIZE * 6)
139139
#define DUMMY_BUF_ALLOC_SIZE (DUMMY_BUF_SIZE * 2)
140140

141141
enum pad_types {

0 commit comments

Comments
 (0)