Skip to content

Commit d12392e

Browse files
Sylwester NawrockiMauro Carvalho Chehab
Sylwester Nawrocki
authored and
Mauro Carvalho Chehab
committed
[media] s5p-fimc: Fail driver probing when sensor configuration is wrong
When a sensor with MIPI-CSI interface is attached through platform data definition and the MIPI-CSI receiver is not selected in kernel configuration s5p-fimc driver probe() will now succeed, issuing only a warning. It was done this way to allow the driver to work even if system configuration is not exactly right. Instead make the driver's probe() fail if a MIPI-CSI sensor was requested but s5p-csis module is not present. Signed-off-by: Sylwester Nawrocki <[email protected]> Signed-off-by: Kyungmin Park <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
1 parent 9c63afc commit d12392e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/media/video/s5p-fimc/fimc-mdevice.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,7 @@ static int fimc_md_create_links(struct fimc_md *fmd)
514514
if (WARN(csis == NULL,
515515
"MIPI-CSI interface specified "
516516
"but s5p-csis module is not loaded!\n"))
517-
continue;
517+
return -EINVAL;
518518

519519
ret = media_entity_create_link(&sensor->entity, 0,
520520
&csis->entity, CSIS_PAD_SINK,

0 commit comments

Comments
 (0)