Skip to content

Commit dae803e

Browse files
mina86torvalds
authored andcommitted
mm: alloc_contig_range: demote pages busy message from warn to info
Having test_pages_isolated failure message as a warning confuses users into thinking that it is more serious than it really is. In reality, if called via CMA, allocation will be retried so a single test_pages_isolated failure does not prevent allocation from succeeding. Demote the warning message to an info message and reformat it such that the text "failed" does not appear and instead a less worrying "PFNS busy" is used. This message is trivially reproducible on a 10GB x86 machine on 3.16.y kernels configured with CONFIG_DMA_CMA. Signed-off-by: Michal Nazarewicz <[email protected]> Cc: Laurent Pinchart <[email protected]> Cc: Peter Hurley <[email protected]> Cc: Minchan Kim <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 95069ac commit dae803e

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

mm/page_alloc.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6397,13 +6397,12 @@ int alloc_contig_range(unsigned long start, unsigned long end,
63976397

63986398
/* Make sure the range is really isolated. */
63996399
if (test_pages_isolated(outer_start, end, false)) {
6400-
pr_warn("alloc_contig_range test_pages_isolated(%lx, %lx) failed\n",
6401-
outer_start, end);
6400+
pr_info("%s: [%lx, %lx) PFNs busy\n",
6401+
__func__, outer_start, end);
64026402
ret = -EBUSY;
64036403
goto done;
64046404
}
64056405

6406-
64076406
/* Grab isolated pages from freelists. */
64086407
outer_end = isolate_freepages_range(&cc, outer_start, end);
64096408
if (!outer_end) {

0 commit comments

Comments
 (0)