Skip to content

Commit eb8f8e7

Browse files
6by9popcornmix
authored andcommitted
drm: vc4: Add comments for which HVS_PIXEL_ORDER_xxx defines apply
The HVS_PIXEL_ORDER_xxx defines apply to specific HVS_PIXEL_FORMAT_xxx modes, so add comments to make this obvious. Signed-off-by: Dave Stevenson <[email protected]>
1 parent 7298360 commit eb8f8e7

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/gpu/drm/vc4/vc4_regs.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -857,16 +857,19 @@ enum hvs_pixel_format {
857857
/* Note: the LSB is the rightmost character shown. Only valid for
858858
* HVS_PIXEL_FORMAT_RGB8888, not RGB888.
859859
*/
860+
/* For modes 332, 4444, 555, 5551, 6666, 8888, 10:10:10:2 */
860861
#define HVS_PIXEL_ORDER_RGBA 0
861862
#define HVS_PIXEL_ORDER_BGRA 1
862863
#define HVS_PIXEL_ORDER_ARGB 2
863864
#define HVS_PIXEL_ORDER_ABGR 3
864865

866+
/* For modes 666 and 888 (4 & 5) */
865867
#define HVS_PIXEL_ORDER_XBRG 0
866868
#define HVS_PIXEL_ORDER_XRBG 1
867869
#define HVS_PIXEL_ORDER_XRGB 2
868870
#define HVS_PIXEL_ORDER_XBGR 3
869871

872+
/* For YCbCr modes (8-12, and 17) */
870873
#define HVS_PIXEL_ORDER_XYCBCR 0
871874
#define HVS_PIXEL_ORDER_XYCRCB 1
872875
#define HVS_PIXEL_ORDER_YXCBCR 2

0 commit comments

Comments
 (0)