Skip to content

Commit f2c248f

Browse files
committed
Revert "net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends"
This reverts commit 88078d9.
1 parent 5ca4ac2 commit f2c248f

File tree

2 files changed

+3
-16
lines changed

2 files changed

+3
-16
lines changed

include/linux/skbuff.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3143,7 +3143,6 @@ static inline void *skb_push_rcsum(struct sk_buff *skb, unsigned int len)
31433143
return skb->data;
31443144
}
31453145

3146-
int pskb_trim_rcsum_slow(struct sk_buff *skb, unsigned int len);
31473146
/**
31483147
* pskb_trim_rcsum - trim received skb and update checksum
31493148
* @skb: buffer to trim
@@ -3157,7 +3156,9 @@ static inline int pskb_trim_rcsum(struct sk_buff *skb, unsigned int len)
31573156
{
31583157
if (likely(len >= skb->len))
31593158
return 0;
3160-
return pskb_trim_rcsum_slow(skb, len);
3159+
if (skb->ip_summed == CHECKSUM_COMPLETE)
3160+
skb->ip_summed = CHECKSUM_NONE;
3161+
return __pskb_trim(skb, len);
31613162
}
31623163

31633164
static inline int __skb_trim_rcsum(struct sk_buff *skb, unsigned int len)

net/core/skbuff.c

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1839,20 +1839,6 @@ int ___pskb_trim(struct sk_buff *skb, unsigned int len)
18391839
}
18401840
EXPORT_SYMBOL(___pskb_trim);
18411841

1842-
/* Note : use pskb_trim_rcsum() instead of calling this directly
1843-
*/
1844-
int pskb_trim_rcsum_slow(struct sk_buff *skb, unsigned int len)
1845-
{
1846-
if (skb->ip_summed == CHECKSUM_COMPLETE) {
1847-
int delta = skb->len - len;
1848-
1849-
skb->csum = csum_sub(skb->csum,
1850-
skb_checksum(skb, len, delta, 0));
1851-
}
1852-
return __pskb_trim(skb, len);
1853-
}
1854-
EXPORT_SYMBOL(pskb_trim_rcsum_slow);
1855-
18561842
/**
18571843
* __pskb_pull_tail - advance tail of skb header
18581844
* @skb: buffer to reallocate

0 commit comments

Comments
 (0)