Skip to content

Commit f9adc73

Browse files
JamesH65Phil Elwell
authored and
Phil Elwell
committed
drm/vc4: Fix for margins in composite/SDTV mode (#3223)
Margins were incorrectly assumed to be setup in SDTV mode, but were not actually done, so this make the setup non-conditional on mode. Signed-off-by: James Hughes <[email protected]>
1 parent 6f7c104 commit f9adc73

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

drivers/gpu/drm/vc4/vc4_firmware_kms.c

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1587,14 +1587,9 @@ vc4_fkms_connector_init(struct drm_device *dev, struct drm_encoder *encoder,
15871587
connector->interlace_allowed = 0;
15881588
}
15891589

1590-
/* Create and attach TV margin props to this connector.
1591-
* Already done for SDTV outputs.
1592-
*/
1593-
if (fkms_connector->display_type != DRM_MODE_ENCODER_TVDAC) {
1594-
ret = drm_mode_create_tv_margin_properties(dev);
1595-
if (ret)
1596-
goto fail;
1597-
}
1590+
ret = drm_mode_create_tv_margin_properties(dev);
1591+
if (ret)
1592+
goto fail;
15981593

15991594
drm_connector_attach_tv_margin_properties(connector);
16001595

0 commit comments

Comments
 (0)