Skip to content

Commit ff223f3

Browse files
committed
drm/vc4: Remove entry to ULPS from vc4_dsi post_disable
Post_disable was sending the D-PHY sequence to put any device into ULPS suspend mode, and then cutting power to the DSI block. The power-on reset state of the DSI block is for DSI to be in an operational state, not ULPS, so it then never sent the sequence for exiting ULPS. Any attached device that didn't have an external reset therefore remained in ULPS / standby, and didn't function. Use of ULPS isn't well specified in DRM, therefore remove entering it to avoid the above situation. Signed-off-by: Dave Stevenson <[email protected]>
1 parent 5d74a18 commit ff223f3

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

drivers/gpu/drm/vc4/vc4_dsi.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -816,8 +816,6 @@ static void vc4_dsi_bridge_post_disable(struct drm_bridge *bridge,
816816
struct vc4_dsi *dsi = bridge_to_vc4_dsi(bridge);
817817
struct device *dev = &dsi->pdev->dev;
818818

819-
vc4_dsi_ulps(dsi, true);
820-
821819
clk_disable_unprepare(dsi->pll_phy_clock);
822820
clk_disable_unprepare(dsi->escape_clock);
823821
clk_disable_unprepare(dsi->pixel_clock);

0 commit comments

Comments
 (0)