Skip to content

Input: xpad - add support for NEW Xbox One controllers #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
drsternau opened this issue Nov 16, 2015 · 7 comments
Closed

Input: xpad - add support for NEW Xbox One controllers #1202

drsternau opened this issue Nov 16, 2015 · 7 comments

Comments

@drsternau
Copy link

When I plug in the new Xbox One Controller (this one has a audio jack) my system crashes.
The issue seems to be the unrecognized id of the controller.
As Erik Lundgren pointed out, this issue can be addressed by adding

{ 0x045e, 0x02dd, "Microsoft X-Box One pad (Covert Forces)", 0, XTYPE_XBOXONE },

as line 128.

It it possible to insert this?

@Ferroin
Copy link
Contributor

Ferroin commented Nov 16, 2015

This is a known issue in upstream Linux, and a patch has been posted there.

@lurch
Copy link

lurch commented Jan 18, 2016

I suspect if you provide a link to the (accepted?) upstream patch, @popcornmix will be happy to pull it into this repo.

@popcornmix
Copy link
Collaborator

@Ferroin can you point at the upstream commit? I'm not seeing it on 4.4 for example.
In general if it is accepted upstream and we can cherry-pick it, we are much more likely to add to the kernel (as the patch will be dropped at some future kernel bump).
If it's not accepted upstream, then we are less likely to pick it.

@Ferroin
Copy link
Contributor

Ferroin commented Jan 18, 2016

I don't know the exact commit, and I don't recall when it got merged, but I'm pretty sure something ended up in 4.3 to fix it.

I can defiantly look though, but it may be tomorrow or Wednesday before I get a chance to.

@popcornmix
Copy link
Collaborator

Okay it seems to be in 4.4:
https://github.com/raspberrypi/linux/blob/rpi-4.4.y/drivers/input/joystick/xpad.c#L128

we are moving to this kernel in the near future and it can be tested early with:
sudo BRANCH=next rpi-update

@Ruffio
Copy link

Ruffio commented Aug 17, 2016

@drsternau has your issue been resolved? If so, please close this issue. Thanks.

@drsternau
Copy link
Author

@Ruffio Sorry! Yeah, the issue has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants