added workarounds for windows cert .nokey failure & moved the domain name injection to the build stage

Author: rastenis

docker-compose-linux.yml

@@ -13,10 +13,10 @@ services:
         restart: always
         build:
             context: ./nginx-certbot
+            args:
+                DOMAIN: server.company.com
         environment:
-            CERTBOT_EMAIL: [email protected]
-            ENVSUBST_VARS: DOMAIN
-            DOMAIN: server.company.com
+            CERTBOT_EMAIL: [email protected]
         ports:
             - 80:80
             - 443:443

docker-compose-windows.yml

@@ -13,10 +13,10 @@ services:
         restart: always
         build:
             context: ./nginx-certbot
+            args:
+                DOMAIN: server.company.com
         environment:
-            CERTBOT_EMAIL: [email protected]
-            ENVSUBST_VARS: DOMAIN
-            DOMAIN: server.company.com
+            CERTBOT_EMAIL: [email protected]
         ports:
             - 80:80
             - 443:443

nginx-certbot/Dockerfile

@@ -1,4 +1,7 @@
 FROM staticfloat/nginx-certbot
 COPY *.conf /etc/nginx/conf.d/
 
+ARG DOMAIN
+
+RUN sed -i "s/DOMAIN/${DOMAIN}/g" /etc/nginx/conf.d/boiler.conf
 RUN sed -i 's/acme-v01/acme-v02/g' /scripts/util.sh

nginx-certbot/boiler.conf

@@ -1,8 +1,8 @@
 server {
     listen              443 ssl;
-    server_name         ${DOMAIN};
-    ssl_certificate     /etc/letsencrypt/live/${DOMAIN}/fullchain.pem;
-    ssl_certificate_key /etc/letsencrypt/live/${DOMAIN}/privkey.pem;
+    server_name         DOMAIN;
+    ssl_certificate     /etc/letsencrypt/live/DOMAIN/fullchain.pem;
+    ssl_certificate_key /etc/letsencrypt/live/DOMAIN/privkey.pem;
 
     location / {
         proxy_pass http://boiler:80;

readme.md

@@ -74,6 +74,14 @@ If you're behind Nginx or a similar reverse proxy setup, you can either:
 
 Docker on Windows has an open issue with local volume mapping permissions, which results in PostgreSQL not being able to write to a (relative) local directory. Thus, when running on Windows (via run.sh), an external volume is created, which is managed by Docker.
 
+Moreover, if you encounter a PR_END_OF_FILE_ERROR when trying to load the website, try executing:
+
+```
+$ docker exec nginx bash -c "mv /etc/nginx/conf.d/boiler.conf{.nokey,} ; nginx -s reload"
+```
+
+This seems to be a symlink issue with Windows Docker containers as well. After renaming the file once, it does not need to be touched anymore (unless you purge the nginx container).
+
 ### Information & Sources
 
 Documentation for ASP.NET Core can be found here: [.NET Core docs.](https://docs.microsoft.com/aspnet/core)