fix #194: make graceful cleanup the default and let user override that by calling setGracefulCleanup(false)

Author: silkentrance

README.md

@@ -328,13 +328,13 @@ console.log('Created temporary filename: ', tmpname);
 
 ## Graceful cleanup
 
-One may want to cleanup the temporary files even when an uncaught exception
-occurs. To enforce this, you can call the `setGracefulCleanup()` method:
+By default, tmp will clean up all temporary files and empty directories on termination of the process.
+To change this behaviour, you can call `setGracefulCleanup(false)`:
 
 ```javascript
 var tmp = require('tmp');
 
-tmp.setGracefulCleanup();
+tmp.setGracefulCleanup(false);
 ```
 
 ## Options

lib/tmp.js

@@ -45,7 +45,7 @@ const
   _removeObjects = [];
 
 var
-  _gracefulCleanup = false;
+  _gracefulCleanup = true;
 
 /**
  * Random name generator based on crypto.
@@ -571,9 +571,11 @@ function isBlank(s) {
 
 /**
  * Sets the graceful cleanup.
+ *
+ * The default is to always try to clean up the temporary files and empty directories on process termination.
  */
-function setGracefulCleanup() {
-  _gracefulCleanup = true;
+function setGracefulCleanup(graceful) {
+  _gracefulCleanup = graceful != undefined ? graceful : true;
 }
 
 /**

test/dir-sync-test.js

@@ -12,9 +12,6 @@ var
   tmp = require('../lib/tmp');
 
 
-// make sure that everything gets cleaned up
-tmp.setGracefulCleanup();
-
 describe('tmp', function () {
   describe('#dirSync()', function () {
     describe('when running inband standard tests', function () {

test/dir-test.js

@@ -12,10 +12,6 @@ var
   tmp = require('../lib/tmp');
 
 
-// make sure that everything gets cleaned up
-tmp.setGracefulCleanup();
-
-
 describe('tmp', function () {
   describe('#dir()', function () {
     describe('when running inband standard tests', function () {

test/file-sync-test.js

@@ -11,10 +11,6 @@ var
   tmp = require('../lib/tmp');
 
 
-// make sure that everything gets cleaned up
-tmp.setGracefulCleanup();
-
-
 describe('tmp', function () {
   describe('#fileSync()', function () {
     describe('when running inband standard tests', function () {

test/file-test.js

@@ -11,9 +11,6 @@ var
   tmp = require('../lib/tmp');
 
 
-// make sure that everything gets cleaned up
-tmp.setGracefulCleanup();
-
 describe('tmp', function () {
   describe('#file()', function () {
     describe('when running inband standard tests', function () {

test/outband/issue121.js

@@ -7,8 +7,6 @@ const
 // https://github.com/raszi/node-tmp/issues/121
 module.exports = function () {
 
-  tmp.setGracefulCleanup();
-
   const result = tmp.dirSync({ unsafeCleanup: true });
 
   this.out(result.name, function () { });

test/spawn-generic.js

@@ -15,7 +15,7 @@ if (config.async) fnUnderTest = (config.file) ? tmp.file : tmp.dir;
 else fnUnderTest = (config.file) ? tmp.fileSync : tmp.dirSync;
 
 // do we test against tmp doing a graceful cleanup?
-if (config.graceful) tmp.setGracefulCleanup();
+tmp.setGracefulCleanup(config.graceful)
 
 // import the test case function and execute it
 var fn = require(path.join(__dirname, 'outband', config.tc));