feat(android): Use Room library for persistent storage #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krizzu
force-pushed
the
feat/android-room
branch
4 times, most recently
from
ec73170 to
69a6c95
Compare
krizzu
commented
Feb 17, 2021
android/src/main/java/com/reactnativecommunity/asyncstorage/AsyncStorageModule.java
Show resolved
Hide resolved
tido64
approved these changes
Feb 24, 2021
android/src/main/java/com/reactnativecommunity/asyncstorage/AsyncStorageModule.java
Show resolved
Hide resolved
android/src/main/java/com/reactnativecommunity/asyncstorage/next/ArgumentHelpers.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativecommunity/asyncstorage/next/ErrorHelpers.kt
Show resolved
Hide resolved
android/src/test/java/com/reactnativecommunity/asyncstorage/next/StorageTest.kt
Show resolved
Hide resolved
added 14 commits
February 26, 2021 09:43
Functionality to persist data, new example, error handling
krizzu
force-pushed
the
feat/android-room
branch
2 times, most recently
from
249dfbd to
a62ce70
Compare
krizzu
force-pushed
the
feat/android-room
branch
from
a62ce70 to
baa5e6c
Compare
krizzu
force-pushed
the
feat/android-room
branch
4 times, most recently
from
27ed528 to
a74d613
Compare
krizzu
force-pushed
the
feat/android-room
branch
2 times, most recently
from
86114f9 to
b388e87
Compare
krizzu
force-pushed
the
feat/android-room
branch
from
b388e87 to
70de3b0
Compare
4 tasks
|
🎉 This PR is included in version 1.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Ashoat
added a commit
to CommE2E/comm
that referenced
this pull request
Apr 30, 2021
Summary: Android wasn't persisting the Redux store when logged in with the "ashoat" user. I saw the "Row too big to fit into CursorWindow" error, so I Googled around and found this hack in a [GitHub issue](react-native-async-storage/async-storage#537). The long-term fix is for us to move the database stuff to SQLite. For completeness, here are some other fixes I considered: 1. [react-native-mmkv](https://github.com/mrousavy/react-native-mmkv) as storage for `redux-persist` (not confident it will handle huge pages better though) 2. [Separating reducers](rt2zz/redux-persist#1265 (comment)) into distinct `AsyncStorage` keys (not sure what the distribution of size by keys is, and might require a migration) 3. Upgrading `AsyncStorage` and investing [this](https://react-native-async-storage.github.io/async-storage/docs/advanced/db_size) (people on the issue said it didn't help) 4. [Moving](react-native-async-storage/async-storage#528) off of SQLite storage onto Android Room storage (people on the issue said it didn't help) I think using this hack for now is a good stopgap. Test Plan: Make sure Android is loading the persisted store correctly when the app starts Reviewers: palys-swm Reviewed By: palys-swm Subscribers: KatPo, Adrian, atul Differential Revision: https://phabricator.ashoat.com/D1069
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current implementation of Sqlite access is cumbersome, error prone and produces some hard to reproduce errors to users. This PR aims to improve our native implementation of SQLite access and thread control.
About
This PR introduced the "next" storage implementation. Room has been used for database access, and Coroutines to handle asynchronous work.
I tried to reuse old database file, but due to it having a SQLite bug (where
primary keycan be null, which is a SQLite violation that Room is guarded against) I had to provide a migration path to copy over values to new database. This operation is done only once, the very first time feature is switched on.No developer migration is necessary to start using this feature. It means that, once switched on, the same data stored so far will be available to use. No API change on JS side is involved. One notable change that can be somehow breaking is how this feature handle AsyncStorage rules violation - if
keyused is not string (or null) ORvalueis not a string, then error with proper message is thrown. No more cryptic sqlite errors.As part of this PR and feature, some new enhancement:
Test plan
Green CI, manual test on the Example App.