Skip to content

Added testresults.gradle in bundle as it is required to install on android using next storage #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gabrielbull
Copy link
Contributor

@gabrielbull gabrielbull commented Apr 2, 2021

Install fails on android using next version because of this line in build.gradle created by @krizzu. It requires a file that is not included in the bundled async storage library.

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
-----------
* Where:
Build file '~/project/node_modules/@react-native-async-storage/async-storage/android/build.gradle' line: 72

* What went wrong:
A problem occurred evaluating project ':react-native-async-storage_async-storage'.
> Could not read script '~/project/node_modules/@react-native-async-storage/async-storage/android/testresults.gradle' as it does not exist.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================

image

Summary

Test Plan

Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks a lot!

@krizzu krizzu merged commit f5f1fed into react-native-async-storage:master Apr 2, 2021
@krizzu
Copy link
Member

krizzu commented Apr 2, 2021

🎉 This PR is included in version 1.15.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@krizzu krizzu added the released label Apr 2, 2021
@@ -13,6 +13,7 @@
"types/",
"android/src",
"android/build.gradle",
"android/testresults.gradle",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krizzu: Why is this published? Shouldn't the script just not apply this file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that'd be a follow up PR to apply this conditionally

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe we could just inline it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants