-
Notifications
You must be signed in to change notification settings - Fork 89
Not possible to pass TestID to the tabs #873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@dwightdhooge I made a patch-package patch for this: Create Paste:
@Naturalclar would be amazing to have this in the lib so a patch isn't needed. |
@markymc thanks for the ping! will make a PR and publish new version today |
@Naturalclar thanks so much for the quick response! (Also I see you're just down the road in Chiba! I'm in Shibuya 😊) |
@Naturalclar I just tried the new version and for some reason now my tests (Cypress on Web) are failing. However, if I apply the following change, they start passing again:
Actually, looking at my initial patch, I don't really understand how my tests ever passed! There's no I'm in the middle of a lot of dependency upgrades so I'm not sure what changed that causes those tests to not pass now (or conversely why they were passing when they shouldn't have), but if I find out I'll let you know. |
Uh oh!
There was an error while loading. Please reload this page.
Possible to add testID to the tabs ? so we can identify It easiliy in automation
<TouchableOpacity style={[styles.container, tabStyle]} disabled={!enabled} onPress={onSelect} accessibilityHint={accessibilityHint} testID={testID}
...
The text was updated successfully, but these errors were encountered: