Skip to content

invalid index.d.ts for typescript typings #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
28harishkumar opened this issue Jan 16, 2020 · 1 comment
Closed

invalid index.d.ts for typescript typings #146

28harishkumar opened this issue Jan 16, 2020 · 1 comment

Comments

@28harishkumar
Copy link
Contributor

Typings for interface IOptions is wrong in following line.

It must be

    supportsVideo?: boolean,
    maximumCallGroups?: string,
    maximumCallsPerCallGroup?: string,

false, '1' and '1' are values not types. Also according to setup these fields are options.

Seems like this minor update has not tested for typescript.

@danjenkins
Copy link
Collaborator

Hey @28harishkumar - thanks for this but theres already another issue for this over at #121

Maybe you could do a Pull Request to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants