From 551dee98b0bf3d9c8f803ec00b43e74dde4c7e58 Mon Sep 17 00:00:00 2001 From: Sanjay Guruprasad Date: Fri, 10 Jan 2020 18:01:40 -0800 Subject: [PATCH 1/2] Add a troubleshooting note on using a valid uuid Was stuck for some time trying to figure out why the incoming call wasn't being received and it turned out, it was simply because I had supplied an invalid `uuid`. The `didDisplayIncomingCall` method also returns without any errors, so there's no explanation for why the screen didn't show up. Might be great if the library threw an error in `didDisplayIncomingCall` if an invalid `uuid` is supplied. --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index 1cdc3d2e..889cea13 100644 --- a/README.md +++ b/README.md @@ -667,6 +667,9 @@ Since iOS 13, you'll have to report the incoming calls that wakes up your applic adb logcat *:S RNCallKeepModule:V ``` +## Troubleshooting +- Ensure that you use a valid `uuid` using the uuid library as shown in the examples (not a custom string), otherwise the incoming call screen will never be shown on iOS. + ## Contributing Any pull request, issue report and suggestion are highly welcome! From 622bc32d83900761ed53336e2b7939820ed257a9 Mon Sep 17 00:00:00 2001 From: Sanjay Guruprasad Date: Mon, 13 Jan 2020 12:20:01 -0800 Subject: [PATCH 2/2] Improve troubleshooting text to say uuid.v4() --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 889cea13..37a80dd3 100644 --- a/README.md +++ b/README.md @@ -668,7 +668,7 @@ adb logcat *:S RNCallKeepModule:V ``` ## Troubleshooting -- Ensure that you use a valid `uuid` using the uuid library as shown in the examples (not a custom string), otherwise the incoming call screen will never be shown on iOS. +- Ensure that you construct a valid `uuid` by importing the `uuid` library and running `uuid.v4()` as shown in the examples. If you don't do this and use a custom string, the incoming call screen will never be shown on iOS. ## Contributing