Overall Fixes #174
Merged
Overall Fixes #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r introducing JSX, just a few words
tesseralis
reviewed
Feb 18, 2019
tesseralis
reviewed
Feb 18, 2019
10 tasks
|
Hey guys 💪 I finished it 🎊 So basically, I checked core pages, and some of the advanced ones The things that I encountered were these:
I think that was all, I'll certainly skipped one or two but that's most of it. Please take a look (I know it's a lot) but with this I think that we fix various issues 🚀 Thank you guys! I'll be looking for your feedback 📓 |
|
Holy cow, this is a huge (and amazing) PR - I’ll take a look at it tonight! You’re a hero 🎖 |
|
I'll take a look later, probably tonight. Great job! 💪 |
carburo
reviewed
Feb 20, 2019
examples/react-component-reference/get-snapshot-before-update.js
Outdated
Show resolved
Hide resolved
Co-Authored-By: Darking360 <[email protected]>
Co-Authored-By: Darking360 <[email protected]>
Co-Authored-By: Darking360 <[email protected]>
Co-Authored-By: Darking360 <[email protected]>
Co-Authored-By: Darking360 <[email protected]>
Co-Authored-By: Darking360 <[email protected]>
Co-Authored-By: Darking360 <[email protected]>
Co-Authored-By: Darking360 <[email protected]>
Co-Authored-By: Darking360 <[email protected]>
|
Deploy preview for es-reactjs ready! Built with commit 3b2fb0f |
|
Greetings guys! I just added @carburo feedback. If you could take a last look before merging this would be awesome! |
|
Deploy preview for es-reactjs ready! Built with commit f3c5288 |
|
Deploy preview for es-reactjs ready! Built with commit 06aff0c |
alejandronanez
approved these changes
Feb 21, 2019
| @@ -147,7 +147,7 @@ return ( | |||
| ); | |||
| ``` | |||
|
|
|||
| Estos dos fragmentos de código son equivalentes. Mientras **JSX es [completamente opcional](/docs/react-without-jsx.html)**, muchas personas lo encuentran útil para escribir código relacionado con la IU -- ya sea usando React o con otras bibliotecas. | |||
| Estos dos fragmentos de código son equivalentes. Mientras **JSX es [completamente opcional](/docs/react-without-jsx.html)**, muchas personas lo encuentran útil para escribir código relacionado con la interfaz de usuario -- ya sea usando React o con otras bibliotecas. | |||
| @@ -33,7 +33,7 @@ El equipo de React principalmente recomienda las siguientes soluciones: | |||
| - Si estás **aprendiendo React** o **creando una nueva [aplicación de página única](/docs/glossary.html#single-page-application),** usa [Create React App](#create-react-app). | |||
| - Si estás construyendo un **sito web renderizado en servidor con Node.js,** prueba [Next.js](#nextjs). | |||
| - Si estás construyendo un **sitio web orientado a contenido estático,** prueba [Gatsby](#gatsby). | |||
| - Si estás construyendo una **biblioteca de componentes** o **integrando una base de código existente**, prueba [Cadenas de Herramientas más Flexibles](#cadenas-de-herramientas-ms-flexibles). | |||
| - Si estás construyendo una **biblioteca de componentes** o **integrando una base de código existente**, prueba [Cadenas de Herramientas más Flexibles](#more-flexible-toolchains). | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translation: Overall Fixes
Related: Original issue: Spanish Translation Final Tasks!
Overall checking on going, reading all core pages and submitting some changes and fixes.