Skip to content

Failure to sync with master with bot due to protected branch #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tesseralis opened this issue Feb 27, 2019 · 3 comments
Closed

Failure to sync with master with bot due to protected branch #115

tesseralis opened this issue Feb 27, 2019 · 3 comments

Comments

@tesseralis
Copy link
Member

I tried running the sync bot but it's failing because the master branch is protected.

remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: Required status check "ci/circleci: build" is expected. At least 1 approving review is required by reviewers with write access.
To https://github.com/reactjs/it.reactjs.org.git
 ! [remote rejected]   master -> master (protected branch hook declined)
error: failed to push some refs to 'https://github.com/reactjs/it.reactjs.org.git'

The bot automatically commits if it doesn't detect any conflicts -- no conflicts usually mean the changes are code-related or in a page that isn't translated yet.

I'm okay with writing some logic to get around this, but I was just wondering if you all would be okay with dropping the restrictions. For example, the main reactjs.org repo doesn't even have it:

screen shot 2019-02-27 at 2 31 43 pm

@deblasis
Copy link
Collaborator

Hi @tesseralis! I have seen the same branch protection in some other translation project few days ago, however, I just removed it.

@deblasis
Copy link
Collaborator

I have approved #116 but not merged it yet (no conflicts). Up to you if you wanna do that or abandon it and try again with the bot now that the condition above has been removed.

@deblasis
Copy link
Collaborator

deblasis commented Mar 1, 2019

Closing the issue since #116 was merged

@deblasis deblasis closed this as completed Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants