Merge pull request #455 from danott/polyfill-cleanup

Use .js files for CONSOLE_POLYFILL and CONSOLE_REPLAY

Author: Robert Mosolgo

lib/react/server_rendering/sprockets_renderer.rb

@@ -5,6 +5,10 @@
 module React
   module ServerRendering
     class SprocketsRenderer < ExecJSRenderer
+      # Reimplement console methods for replaying on the client
+      CONSOLE_POLYFILL = File.read(File.join(File.dirname(__FILE__), "sprockets_renderer/console_polyfill.js"))
+      CONSOLE_REPLAY   = File.read(File.join(File.dirname(__FILE__), "sprockets_renderer/console_replay.js"))
+
       def initialize(options={})
         @replay_console = options.fetch(:replay_console, true)
         filenames = options.fetch(:files, ["react-server.js", "components.js"])
@@ -35,29 +39,6 @@ def render(component_name, props, prerender_options)
       def after_render(component_name, props, prerender_options)
         @replay_console ? CONSOLE_REPLAY : ""
       end
-
-      # Reimplement console methods for replaying on the client
-      CONSOLE_POLYFILL = <<-JS
-        var console = { history: [] };
-        ['error', 'log', 'info', 'warn'].forEach(function (fn) {
-          console[fn] = function () {
-            console.history.push({level: fn, arguments: Array.prototype.slice.call(arguments)});
-          };
-        });
-      JS
-
-      # Replay message from console history
-      CONSOLE_REPLAY = <<-JS
-        (function (history) {
-          if (history && history.length > 0) {
-            result += '\\n<scr'+'ipt>';
-            history.forEach(function (msg) {
-              result += '\\nconsole.' + msg.level + '.apply(console, ' + JSON.stringify(msg.arguments) + ');';
-            });
-            result += '\\n</scr'+'ipt>';
-          }
-        })(console.history);
-      JS
     end
   end
 end

lib/react/server_rendering/sprockets_renderer/console_polyfill.js

@@ -0,0 +1,6 @@
+var console = { history: [] };
+['error', 'log', 'info', 'warn'].forEach(function (fn) {
+  console[fn] = function () {
+    console.history.push({level: fn, arguments: Array.prototype.slice.call(arguments)});
+  };
+});

lib/react/server_rendering/sprockets_renderer/console_replay.js

@@ -0,0 +1,9 @@
+(function (history) {
+  if (history && history.length > 0) {
+    result += '\\n<scr'+'ipt>';
+    history.forEach(function (msg) {
+      result += '\\nconsole.' + msg.level + '.apply(console, ' + JSON.stringify(msg.arguments) + ');';
+    });
+    result += '\\n</scr'+'ipt>';
+  }
+})(console.history);