Skip to content

Commit f4806e3

Browse files
author
Robert Mosolgo
authored
Merge pull request #551 from bogdan-dumitru/550-fix-initialize-order
Run initializer blocks after :load_config_initializers
2 parents 7fa90ea + d2a09c3 commit f4806e3

File tree

3 files changed

+17
-3
lines changed

3 files changed

+17
-3
lines changed

lib/react/rails/railtie.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class Railtie < ::Rails::Railtie
2525
end
2626

2727
# Include the react-rails view helper lazily
28-
initializer "react_rails.setup_view_helpers", group: :all do |app|
28+
initializer "react_rails.setup_view_helpers", after: :load_config_initializers, group: :all do |app|
2929

3030
app.config.react.jsx_transformer_class ||= React::JSX::DEFAULT_TRANSFORMER
3131
React::JSX.transformer_class = app.config.react.jsx_transformer_class
@@ -53,7 +53,7 @@ class Railtie < ::Rails::Railtie
5353
end
5454
end
5555

56-
initializer "react_rails.bust_cache", group: :all do |app|
56+
initializer "react_rails.bust_cache", after: :load_config_initializers, group: :all do |app|
5757
asset_variant = React::Rails::AssetVariant.new({
5858
variant: app.config.react.variant,
5959
addons: app.config.react.addons,
Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,9 @@
11
# Override setting set in application.rb
2-
Rails.application.config.react.addons = true
2+
class CustomComponentMount < React::Rails::ComponentMount
3+
end
4+
5+
Dummy::Application.configure do
6+
config.react.addons = true
7+
config.react.view_helper_implementation = CustomComponentMount
8+
end
9+

test/react/rails/view_helper_test.rb

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,11 @@ class ViewHelperTest < ActionView::TestCase
1717
render template: "pages/show"
1818
assert_includes(rendered, "React-Rails")
1919
end
20+
21+
test "view helper uses the implementation class set in the initializer" do
22+
assert_equal(
23+
React::Rails::ViewHelper.helper_implementation_class.to_s,
24+
"CustomComponentMount"
25+
)
26+
end
2027
end

0 commit comments

Comments
 (0)