Skip to content

Depreciation warnings with Rails 5 #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
renchap opened this issue Nov 17, 2015 · 1 comment · Fixed by #456
Closed

Depreciation warnings with Rails 5 #404

renchap opened this issue Nov 17, 2015 · 1 comment · Fixed by #456

Comments

@renchap
Copy link

renchap commented Nov 17, 2015

react-rails is using before_filter, which is deprecated in Rails 5 and will disappear in 5.1 :

DEPRECATION WARNING: before_filter is deprecated and will be removed in Rails 5.1. Use before_action instead. (called from block in <module:ControllerLifecycle> at gems/react-rails-290765a1ac14/lib/react/rails/controller_lifecycle.rb:8)
DEPRECATION WARNING: after_filter is deprecated and will be removed in Rails 5.1. Use after_action instead. (called from block in <module:ControllerLifecycle> at gems/react-rails-290765a1ac14/lib/react/rails/controller_lifecycle.rb:9)

before_filter has been renamed to before_action in Rails 4. I dont know what your policy is regarding deprecations like this on not-yet released versions, but I think it might be worth it to switch to the new name and have a compatibility alias for Rails 3.2.

@krzysiek1507
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants