Skip to content

Commit 2de95d5

Browse files
authored
Merge pull request #206 from clue-labs/async
Update test suite to use new reactphp/async package instead of clue/reactphp-block
2 parents 9ccda33 + 1aee49b commit 2de95d5

File tree

4 files changed

+21
-20
lines changed

4 files changed

+21
-20
lines changed

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@
3333
"react/promise-timer": "^1.9"
3434
},
3535
"require-dev": {
36-
"clue/block-react": "^1.2",
37-
"phpunit/phpunit": "^9.3 || ^4.8.35"
36+
"phpunit/phpunit": "^9.3 || ^4.8.35",
37+
"react/async": "^4 || ^3 || ^2"
3838
},
3939
"autoload": {
4040
"psr-4": { "React\\Dns\\": "src" }

tests/Query/TcpTransportExecutorTest.php

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -266,9 +266,9 @@ function ($e) use (&$exception) {
266266
}
267267
);
268268

269-
\Clue\React\Block\sleep(0.01);
269+
\React\Async\await(\React\Promise\Timer\sleep(0.01));
270270
if ($exception === null) {
271-
\Clue\React\Block\sleep(0.2);
271+
\React\Async\await(\React\Promise\Timer\sleep(0.2));
272272
}
273273

274274
/** @var \RuntimeException $exception */
@@ -437,9 +437,9 @@ function ($e) use (&$exception) {
437437
}
438438
);
439439

440-
\Clue\React\Block\sleep(0.01);
440+
\React\Async\await(\React\Promise\Timer\sleep(0.01));
441441
if ($exception === null) {
442-
\Clue\React\Block\sleep(0.2);
442+
\React\Async\await(\React\Promise\Timer\sleep(0.2));
443443
}
444444

445445
/** @var \RuntimeException $exception */
@@ -476,7 +476,7 @@ function ($e) use (&$wait) {
476476
}
477477
);
478478

479-
\Clue\React\Block\sleep(0.2);
479+
\React\Async\await(\React\Promise\Timer\sleep(0.2));
480480
$this->assertTrue($wait);
481481

482482
$this->assertNotNull($client);
@@ -513,7 +513,7 @@ function ($e) use (&$wait) {
513513
}
514514
);
515515

516-
\Clue\React\Block\sleep(0.2);
516+
\React\Async\await(\React\Promise\Timer\sleep(0.2));
517517
$this->assertTrue($wait);
518518

519519
$this->assertNotNull($client);
@@ -548,9 +548,9 @@ function ($e) use (&$exception) {
548548
}
549549
);
550550

551-
\Clue\React\Block\sleep(0.01);
551+
\React\Async\await(\React\Promise\Timer\sleep(0.01));
552552
if ($exception === null) {
553-
\Clue\React\Block\sleep(0.2);
553+
\React\Async\await(\React\Promise\Timer\sleep(0.2));
554554
}
555555

556556
/** @var \RuntimeException $exception */
@@ -600,9 +600,9 @@ function ($e) use (&$exception) {
600600
}
601601
);
602602

603-
\Clue\React\Block\sleep(0.01);
603+
\React\Async\await(\React\Promise\Timer\sleep(0.01));
604604
if ($exception === null) {
605-
\Clue\React\Block\sleep(0.2);
605+
\React\Async\await(\React\Promise\Timer\sleep(0.2));
606606
}
607607

608608
/** @var \RuntimeException $exception */
@@ -652,9 +652,9 @@ function ($e) use (&$exception) {
652652
}
653653
);
654654

655-
\Clue\React\Block\sleep(0.01);
655+
\React\Async\await(\React\Promise\Timer\sleep(0.01));
656656
if ($exception === null) {
657-
\Clue\React\Block\sleep(0.2);
657+
\React\Async\await(\React\Promise\Timer\sleep(0.2));
658658
}
659659

660660
/** @var \RuntimeException $exception */
@@ -687,7 +687,7 @@ public function testQueryResolvesIfServerSendsValidResponse()
687687
$query = new Query('google.com', Message::TYPE_A, Message::CLASS_IN);
688688

689689
$promise = $executor->query($query);
690-
$response = \Clue\React\Block\await($promise, null, 0.2);
690+
$response = \React\Async\await(\React\Promise\Timer\timeout($promise, 0.2));
691691

692692
$this->assertInstanceOf('React\Dns\Model\Message', $response);
693693
}

tests/Query/TimeoutExecutorTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,8 @@ public function testWrappedWillBeCancelledOnTimeout()
113113
$this->assertEquals(0, $cancelled);
114114

115115
try {
116-
\Clue\React\Block\await($promise);
116+
\React\Async\await(\React\Promise\Timer\sleep(0));
117+
\React\Async\await($promise);
117118
$this->fail();
118119
} catch (TimeoutException $exception) {
119120
$this->assertEquals('DNS query for igor.io (A) timed out' , $exception->getMessage());

tests/Query/UdpTransportExecutorTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ function ($e) use (&$wait) {
273273
}
274274
);
275275

276-
\Clue\React\Block\sleep(0.2);
276+
\React\Async\await(\React\Promise\Timer\sleep(0.2));
277277
$this->assertTrue($wait);
278278

279279
$promise->cancel();
@@ -311,7 +311,7 @@ function ($e) use (&$wait) {
311311
}
312312
);
313313

314-
\Clue\React\Block\sleep(0.2);
314+
\React\Async\await(\React\Promise\Timer\sleep(0.2));
315315
$this->assertTrue($wait);
316316

317317
$promise->cancel();
@@ -347,7 +347,7 @@ public function testQueryRejectsIfServerSendsTruncatedResponse()
347347
'DNS query for google.com (A) failed: The DNS server udp://' . $address . ' returned a truncated result for a UDP query',
348348
defined('SOCKET_EMSGSIZE') ? SOCKET_EMSGSIZE : 90
349349
);
350-
\Clue\React\Block\await($promise, null, 0.1);
350+
\React\Async\await(\React\Promise\Timer\timeout($promise, 0.1));
351351
}
352352

353353
public function testQueryResolvesIfServerSendsValidResponse()
@@ -373,7 +373,7 @@ public function testQueryResolvesIfServerSendsValidResponse()
373373
$query = new Query('google.com', Message::TYPE_A, Message::CLASS_IN);
374374

375375
$promise = $executor->query($query);
376-
$response = \Clue\React\Block\await($promise, null, 0.2);
376+
$response = \React\Async\await(\React\Promise\Timer\timeout($promise, 0.2));
377377

378378
$this->assertInstanceOf('React\Dns\Model\Message', $response);
379379
}

0 commit comments

Comments
 (0)